Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Beaver fix; working towards another model #13

Merged
merged 3 commits into from
Feb 9, 2024
Merged

Beaver fix; working towards another model #13

merged 3 commits into from
Feb 9, 2024

Conversation

natolambert
Copy link
Collaborator

@natolambert natolambert commented Feb 8, 2024

Jacob, can you try running this new Ziya model?

@natolambert natolambert changed the title Fix for beaver I forgot to push Beaver fix; working towards another model Feb 8, 2024
@jacob-morrison
Copy link
Contributor

jacob-morrison commented Feb 9, 2024

Ziya works if you use --direct_load, and then you can even crank the batch size to 32. I think the standard pipeline abstraction is inefficient with memory, so we should assume we're using --direct_load for >=7B models.

I'll have results on HERM in ~10 minutes, and then I'll run it on pref sets. I can include these changes in our docker image when this is merged.

@natolambert
Copy link
Collaborator Author

natolambert commented Feb 9, 2024

@jacob-morrison on what GPU? Quantization should be exactly the same in the pipeline abstraction?
I was debugging on A6000

@jacob-morrison
Copy link
Contributor

@jacob-morrison on what GPU? Quantization should be exactly the same in the pipeline abstraction? I was debugging on A6000

It should be, but it's clearly not based on my testing. I was running this on an A100 and I couldn't get it to successfully run on a single example with: batch_size=1, max_length=1024. After switching to direct_load, I could change back to: batch_size=32, max_length=2048, with no other changes.

We also already use direct_load for all other models of the same size or bigger, and I'd imagine we'd run into the same issue for those if we tried to use the pipeline abstraction instead.

@natolambert
Copy link
Collaborator Author

Good to know, I'll add something to the docs that the quantization doesn't always work right for pipeline thanks a lot!

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@jacob-morrison jacob-morrison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@natolambert natolambert merged commit 0299429 into main Feb 9, 2024
3 checks passed
@ljvmiranda921 ljvmiranda921 deleted the beaver_fix branch March 16, 2024 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants