Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak ArmorRM implementation, add args to CLI #194

Merged
merged 4 commits into from
Oct 4, 2024
Merged

Tweak ArmorRM implementation, add args to CLI #194

merged 4 commits into from
Oct 4, 2024

Conversation

natolambert
Copy link
Collaborator

No description provided.

Copy link
Contributor

@vwxyzjn vwxyzjn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -70,6 +71,10 @@ class Args:
"""The batch size to use."""
max_length: int = 512
"""The max length to use."""
torch_dtype: Literal["float16", "bfloat16", "float32", "float64"] = "float16"
"""PyTorch dtype (default: float16)"""
attn_implementation: Optional[Literal["eager", "sdpa", "flash_attention_2"]] = None
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a nice add!

@natolambert natolambert merged commit c8f3fd1 into main Oct 4, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants