-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for additional message properties #1
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a couple little things, otherwise 👍
{ | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
flagging that this is empty... I'm guessing we won't use it anyway.
@@ -114,6 +121,16 @@ public function setPriceAmount(string $PriceAmount) | |||
$this->PriceAmount = (float) $PriceAmount; | |||
} | |||
|
|||
public function getPriceDate(): array |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add docblock?
return $this->PriceDate; | ||
} | ||
|
||
public function setPriceDate(PriceDate $PriceDate): void |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add docblock?
…nix-parser into feature/alley
Composer Lock ChangesThe following is a summary of the changes to the
|
Package | Operation | Previous Version | Version |
---|---|---|---|
psr/container |
🟢 added | 2.0.2 | |
symfony/deprecation-contracts |
🟡 upgraded | v2.5.2 | v3.5.1 |
symfony/polyfill-ctype |
🟡 upgraded | v1.27.0 | v1.31.0 |
symfony/polyfill-intl-grapheme |
🟡 upgraded | v1.27.0 | v1.31.0 |
symfony/polyfill-intl-normalizer |
🟡 upgraded | v1.27.0 | v1.31.0 |
symfony/polyfill-mbstring |
🟡 upgraded | v1.27.0 | v1.31.0 |
symfony/polyfill-php80 |
🔴 removed | v1.27.0 | |
symfony/property-access |
🟡 upgraded | v5.4.15 | v7.2.0 |
symfony/property-info |
🟡 upgraded | v5.4.16 | v7.2.0 |
symfony/serializer |
🟡 upgraded | v5.4.15 | v7.2.0 |
symfony/string |
🟡 upgraded | v5.4.15 | v7.2.0 |
symfony/type-info |
🟢 added | v7.2.0 |
This is an automated summary of the changes to the composer.lock
files in this pull request.
Adds methods for a few Onix tags that we needed for a client project.