Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for additional message properties #1

Open
wants to merge 16 commits into
base: master
Choose a base branch
from

Conversation

dlh01
Copy link
Member

@dlh01 dlh01 commented Apr 17, 2024

Adds methods for a few Onix tags that we needed for a client project.

Copy link

@mogmarsh mogmarsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a couple little things, otherwise 👍

Comment on lines +187 to +188
{
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

flagging that this is empty... I'm guessing we won't use it anyway.

@@ -114,6 +121,16 @@ public function setPriceAmount(string $PriceAmount)
$this->PriceAmount = (float) $PriceAmount;
}

public function getPriceDate(): array

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add docblock?

return $this->PriceDate;
}

public function setPriceDate(PriceDate $PriceDate): void

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add docblock?

@alley-ci
Copy link
Collaborator

alley-ci commented Dec 9, 2024

Composer Lock Changes

The following is a summary of the changes to the composer.lock file(s) in this pull request and should be reviewed carefully:

composer.lock

Package Operation Previous Version Version
psr/container 🟢 added 2.0.2
symfony/deprecation-contracts 🟡 upgraded v2.5.2 v3.5.1
symfony/polyfill-ctype 🟡 upgraded v1.27.0 v1.31.0
symfony/polyfill-intl-grapheme 🟡 upgraded v1.27.0 v1.31.0
symfony/polyfill-intl-normalizer 🟡 upgraded v1.27.0 v1.31.0
symfony/polyfill-mbstring 🟡 upgraded v1.27.0 v1.31.0
symfony/polyfill-php80 🔴 removed v1.27.0
symfony/property-access 🟡 upgraded v5.4.15 v7.2.0
symfony/property-info 🟡 upgraded v5.4.16 v7.2.0
symfony/serializer 🟡 upgraded v5.4.15 v7.2.0
symfony/string 🟡 upgraded v5.4.15 v7.2.0
symfony/type-info 🟢 added v7.2.0

This is an automated summary of the changes to the composer.lock files in this pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants