Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

➕ Add a plugin to display the next zenika formation. #294

Merged
merged 1 commit into from
Feb 17, 2018

Conversation

maeln
Copy link
Contributor

@maeln maeln commented Feb 9, 2018

This PR add a submodule for the plugin zenika-formations, which display a list, and optionally details, about the next formations at a Zenika agency.

This PR is related to the issue #293 .
Here is the configuration of the plugins:

{
      "name": "Formation Zenika",
      "description": "Display a list of the next Zenika formation.",
      "eltName": "marcel-plugin-zenika-formations",
      "icon": "picture_in_picture_alt",
      "frontend": {
        "props": [
          {
            "name": "agency",
            "description": "Name of the Zenika agency.",
            "type": "string",
            "value": "nantes"
          },
          {
            "name": "titleMessage",
            "description": "Title message. If it contains {agency}, it will be replaced by the agency name.",
            "type": "string",
            "value": "Next formations in {agency}"
          },
          {
            "name": "displayTime",
            "description": "Number of seconds before switching selection.",
            "type": "float",
            "value": 10.0
          },
          {
            "name": "locale",
            "description": "Langage to use for the date.",
            "type": "string",
            "value": "en"
          },
          {
            "name": "dualpane",
            "description": "If the display should be single pane or dual pane.",
            "type": "bool",
            "value": true
          },
          {
            "name": "selectedColor",
            "description": "The color that will be used to highlight the currently displayed formation.",
            "type": "string",
            "value": "rgba(222, 33, 33, 0.85)"
          },
          {
            "name": "headerColor",
            "description": "The color of the headers.",
            "type": "string",
            "value": "rgba(222, 33, 33, 0.85)"
          }
        ]
      }
    }

@maeln maeln added the plugin label Feb 9, 2018
@maeln maeln self-assigned this Feb 9, 2018
@maeln maeln requested a review from EmrysMyrddin February 9, 2018 16:09
@nlepage
Copy link
Member

nlepage commented Feb 9, 2018

@EmrysMyrddin we need to stop using submodules
Is it normal to have tinycolor.js and moment.js commited in the subrepository ?!
Why is there an identical marcel.js commited in every (not polymer) sub repository ?!

@maeln Nice work 👍 don't worry I'm just asking questions

@maeln
Copy link
Contributor Author

maeln commented Feb 10, 2018

I do agree that putting the dependencies straight in the plugin is not the proper way to do it.
Is there a "official" way to handle the dependencies for MARCEL's plugins (like npm or similar) ?
We should also definitely have way to share marcel.js between repo, since it seems we are going to use it everywhere.

@EmrysMyrddin
Copy link
Collaborator

@nlepage Yes, we have to find an other way to handle plugins. We are using theim beacause we don't have a "plugin market place" for now. so having plugins in as submodules allow us to automaticaly update them with CricleCI.

For the marcel.js, We have to make a seperate library, but we have to think about the way we will do this. I have thought of an npm package, but I also would like to allow users to use this lib as a simple <script> import.

@nlepage
Copy link
Member

nlepage commented Feb 12, 2018

OK let's talk about this in slack.

@nlepage nlepage force-pushed the plugins/feature/zenika_formation#293 branch from 0238a1f to 1b838c1 Compare February 15, 2018 11:21
@maeln maeln requested a review from aorenge as a code owner February 15, 2018 11:21
@nlepage nlepage changed the base branch from dev to master February 15, 2018 11:21
@EmrysMyrddin EmrysMyrddin changed the title ✨ Add a plugin to display the next zenika formation. ➕ Add a plugin to display the next zenika formation. Feb 17, 2018
@EmrysMyrddin EmrysMyrddin merged commit 92108d1 into master Feb 17, 2018
@EmrysMyrddin EmrysMyrddin deleted the plugins/feature/zenika_formation#293 branch May 6, 2019 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants