Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SCRUM-4667 make AgmAgmAssociation live under the general AgmAssociati… #1816

Open
wants to merge 9 commits into
base: alpha
Choose a base branch
from
Open

SCRUM-4667 make AgmAgmAssociation live under the general AgmAssociati… #1816

wants to merge 9 commits into from
+74 −62

Conversation

cmpich
Copy link
Contributor

@cmpich cmpich commented Jan 22, 2025

…on load job

oblodgett
oblodgett requested changes Jan 22, 2025
View reviewed changes
Copy link
Member

@oblodgett oblodgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to have migration to change the column name in the database and indexes

markquintontulloch
markquintontulloch requested changes Jan 23, 2025
View reviewed changes
Copy link
Member

@markquintontulloch markquintontulloch left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You also need a migration to delete the "AGM AGM Association" load group and loads created in the previous PR

@cmpich cmpich requested a review from oblodgett January 30, 2025 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markquintontulloch markquintontulloch markquintontulloch approved these changes

@oblodgett oblodgett Awaiting requested review from oblodgett

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cmpich @oblodgett @markquintontulloch