fixed lca bug + fixed tests

- Alliance bug AGR 1569 was caused by max num of terms for lca not passed correctly and always set to default value 3
alliance-genome · May 7, 2019 · de65340 · de65340
1 parent 0cfd923
commit de65340
Show file tree

Hide file tree

Showing 4 changed files with 94 additions and 120 deletions.
diff --git a/genedescriptions/ontology_tools.py b/genedescriptions/ontology_tools.py
@@ -303,7 +303,7 @@ def get_best_nodes(terms, trimming_algorithm, max_terms, ontology, terms_already
             nodeids_blacklist=nodeids_blacklist)
     elif trimming_algorithm == "lca":
         add_others, merged_terms_coverset = get_best_nodes_lca(
-            node_ids=list(terms), ontology=ontology, min_distance_from_root=min_dist_from_root,
+            node_ids=list(terms), ontology=ontology, min_distance_from_root=min_dist_from_root, max_num_nodes=max_terms,
             nodeids_blacklist=nodeids_blacklist)
     if ancestors_covering_multiple_children is not None:
         ancestors_covering_multiple_children.update({ontology.label(term_id, id_if_null=True) for