feat: ensure building moveit succeeds on all machines (hopefully) #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Wim-Peter Dirks <[email protected]>
WPDOrdina
force-pushed
the
feat/improve-build
branch
from
8b7d04a
to
4a8ea88
Compare
Signed-off-by: Wim-Peter Dirks <[email protected]>
…y if RAM is restricted Signed-off-by: Wim-Peter Dirks <[email protected]>
Signed-off-by: Jelmer de Wolde <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nu kan er (als het goed is) met elke machine met genoeg (>14gb) RAM het franka image gebouwd worden.
Het run-script heb ik ook wat aangepast om hem leesbaarder en simpeler te maken. Ook wordt de image nu direct gedraaid als hij nog gebouwd moet worden. Hiervoor moest het run-script opnieuw gedraaid worden.
Ten slotte heeft de numpy-dependency een minimale versie gekregen, de requirement is nu expliciet ipv impliciet.