Add Cookie.IsSet()

[Alienmario]

Adds a simple QoL method that checks whether a cookie has been set.

[asherkin]

This feels like a responsibility that should possibly belong to `Get`. A non-breaking enhancement could be something like: ``` public native bool Get(int client, char[] buffer, int maxlen, const char[] defaultValue = ""); ``` Where the impl returns `true` if it was truly set and buffer has been populated with the set value, and `false` if it has come from the passed in default. This provides correct logic for plugins where empty might be a desired actual value, and simplifies cases where plugins want to just get a reasonable value and don't care where it has come from. I don't think there's much value in a `Has` if it has to get the value internally anyway.

…

On Sun, 10 Nov 2024 at 12:06, Alienmario ***@***.***> wrote: Adds a simple QoL method that checks whether a cookie has been set. ------------------------------ You can view, comment on, or merge this pull request online at: #2218 Commit Summary - d5bf315 <d5bf315> Add Cookie.IsSet() File Changes (1 file <https://github.com/alliedmodders/sourcemod/pull/2218/files>) - *M* plugins/include/clientprefs.inc <https://github.com/alliedmodders/sourcemod/pull/2218/files#diff-a33c49e43f94315b5864f20889205ddd6f801e73aa0f7efb8924ff960da590b6> (11) Patch Links: - https://github.com/alliedmodders/sourcemod/pull/2218.patch - https://github.com/alliedmodders/sourcemod/pull/2218.diff — Reply to this email directly, view it on GitHub <#2218>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAGTIUHD473GWHE5A4G2MSDZ75D3VAVCNFSM6AAAAABRQERQVKVHI2DSMVQWIX3LMV43ASLTON2WKOZSGY2DOMJXGQ2DAMI> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

[Alienmario]

This is just a simple stock I've been using that helps keep client code clear of char arrays. I've assumed that "unset" is equal to "empty string", since plugins have had no way distinguish so far.

Anyway, since GetFloat/GetInt has been added, I've had no use for the original Get.
I think there's room for both changes. One could prompt new players to set their preferences, for example.