Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(multicall): impl Error for Failure + clear returns Empty builder. #2043

Merged
merged 3 commits into from
Feb 11, 2025

Conversation

yash-atreya
Copy link
Member

Motivation

  1. We can't use ? on a multicall Result<(), Failure> since Failure doesn't implement StdError.
  2. clear should return an Empty multicall builder otherwise it's of no use.

Solution

  1. Use thiserror::Error for Failure
  2. Return Empty multicall builder on multicall.clear()

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

@mattsse mattsse enabled auto-merge (squash) February 11, 2025 15:29
@mattsse mattsse merged commit 56c21da into main Feb 11, 2025
27 checks passed
@mattsse mattsse deleted the yash/multicall-fixes branch February 11, 2025 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants