Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump alloy and remove OpExecutionPayloadV4 #176

Merged
merged 2 commits into from
Oct 18, 2024

Conversation

onbjerg
Copy link
Member

@onbjerg onbjerg commented Oct 18, 2024

Motivation

There is no longer a V4 execution payload in Pectra, so it does not make sense that there would be one for Optimism. The v4 payload envelope still exists, but it now wraps a v3 payload.

See also alloy-rs/alloy#1383

Based on #175

Solution

Remove the V4 payload.

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we assume for now that this will also be the case for op

@mattsse
Copy link
Member

mattsse commented Oct 18, 2024

pending alloy release

@mattsse mattsse mentioned this pull request Oct 18, 2024
3 tasks
@onbjerg onbjerg changed the base branch from yash/bump-alloy to main October 18, 2024 14:13
@onbjerg onbjerg changed the title chore: remove OpExecutionPayloadV4 chore: bump alloy and remove OpExecutionPayloadV4 Oct 18, 2024
There is no longer a V4 execution payload in Pectra,
so it does not make sense that there would be one for
Optimism. The v4 payload envelope still exists,
but it now wraps a v3 payload.
@mattsse mattsse added this pull request to the merge queue Oct 18, 2024
Merged via the queue into main with commit 1f260e0 Oct 18, 2024
19 checks passed
@mattsse mattsse deleted the onbjerg/rm-exec-payload-v4 branch October 18, 2024 14:17
refcell pushed a commit that referenced this pull request Oct 22, 2024
## Motivation

There is no longer a V4 execution payload in Pectra, so it does not make
sense that there would be one for Optimism. The v4 payload envelope
still exists, but it now wraps a v3 payload.

See also alloy-rs/alloy#1383

Based on #175

## Solution

Remove the V4 payload.

## PR Checklist

- [ ] Added Tests
- [ ] Added Documentation
- [ ] Breaking changes

---------

Co-authored-by: Yash Atreya <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants