Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: empty root node #36

Merged
merged 2 commits into from
Sep 17, 2024
Merged

feat: empty root node #36

merged 2 commits into from
Sep 17, 2024

Conversation

rkrasiuk
Copy link
Member

Description

Adds TrieNode::EmptyRoot variant. Proofs for empty trie now contain at least empty root node.

clabby
clabby approved these changes Sep 17, 2024
View reviewed changes
Copy link

@clabby clabby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. We currently work around this on the consumer end of alloy-trie, but will be nice to have support for getting an empty node in the proof retainer w/o handling that special case.

@rkrasiuk rkrasiuk marked this pull request as ready for review September 17, 2024 18:38
@rkrasiuk rkrasiuk merged commit 73ff484 into main Sep 17, 2024
21 checks passed
@rkrasiuk rkrasiuk deleted the rkrasiuk/empty-root-node branch September 17, 2024 20:45
mattsse
mattsse reviewed Sep 17, 2024
View reviewed changes
Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @DaniPopes

src/proof/verify.rs Show resolved Hide resolved
@mattsse mattsse mentioned this pull request Sep 17, 2024
Merged
@rkrasiuk rkrasiuk mentioned this pull request Sep 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse left review comments

@clabby clabby clabby approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rkrasiuk @clabby @mattsse