perf: change proof internal repr to HashMap
#43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
approved these changes
Sep 26, 2024
| pub fn take_proofs(&mut self) -> BTreeMap<Nibbles, Bytes> { | ||
| self.proof_retainer.take().map(ProofRetainer::into_proofs).unwrap_or_default() | ||
| /// Take and return retained proof nodes. | ||
| pub fn take_proof_nodes(&mut self) -> ProofNodes { |
There was a problem hiding this comment.
this is breaking, but so is the type change, so doesn't matter imo
There was a problem hiding this comment.
this is not only a helper struct, but also forces users to revise their usage of proof nodes, because they might rely on them being sorted already (e.g. like we do in reth)
DaniPopes
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Change proof internal representation to
HashMap. Proofs can be sorted once on demand.Introduce new
ProofNodesstruct returned byProofRetainerand a bunch of utility methods for working with it.