Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add DecodedProofNodes struct #81

Merged
merged 1 commit into from
Feb 7, 2025

Conversation

Rjected
Copy link
Contributor

@Rjected Rjected commented Feb 7, 2025

This adds a decoded version of ProofNodes, this could be used to build a decoded version of a multiproof

@Rjected Rjected added the enhancement New feature or request label Feb 7, 2025
@Rjected Rjected force-pushed the add-decoded-proof-nodes branch from f51db45 to 7cda44c Compare February 7, 2025 21:42
Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, mirrors ProofNodes api

I guess technicaly we could unify this via a Value generic but I'd rather duplicate the type+functions

use alloy_rlp::Decodable;
use core::ops::Deref;

#[allow(unused_imports)]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need this, I see Vec being used below

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whoops nope, is copypasta from proof_nodes

@Rjected Rjected force-pushed the add-decoded-proof-nodes branch from 7cda44c to a2ba7e0 Compare February 7, 2025 22:31
@Rjected Rjected merged commit 77ab71a into alloy-rs:main Feb 7, 2025
20 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants