Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for value of $this->severity_key prior to stripos #14

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

drupov
Copy link

@drupov drupov commented Feb 25, 2021

In src/Allure/Behat/Formatter/AllureFormatter.php the check if (stripos($tag, $this->severity_key) === 0) { happens without checking if $this->severity_key has a value. With PHP 7.4 non-string needles are being interpreted as string and of $this->severity_key has e.g. the value of NULL results in an error.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants