Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ConfigureAwait(false) in WrapAsync to avoid SynchronizationContext switch #332

Open
wants to merge 1 commit into
base: nunit-refactorings-1
Choose a base branch
from

Conversation

vanbukin
Copy link

@vanbukin vanbukin commented Feb 18, 2023

Remove ConfigureAwait(false) to avoid switching into default SynchronizationContext.

Context

We have SpecFlow + NUnit + Allure libs in the same project.
SpecFlow uses it's own SynchronizationContext. Async code that executes inside methods that marked as [AllureStep] will always switch into default SynchronizationContext.

Checklist

@CLAassistant
Copy link

CLAassistant commented Feb 18, 2023

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants