code style

allure-framework · Dec 1, 2023 · 0cb5ebf · 0cb5ebf
1 parent 92e8a5d
commit 0cb5ebf
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 5 deletions.
diff --git a/allure-descriptions-javadoc/src/main/java/io/qameta/allure/description/ClassNames.java b/allure-descriptions-javadoc/src/main/java/io/qameta/allure/description/ClassNames.java
@@ -22,4 +22,7 @@ final class ClassNames {
 
     static final String DESCRIPTION_ANNOTATION = "io.qameta.allure.Description";
 
+    private ClassNames() {
+        throw new IllegalStateException("do not instance");
+    }
 }
diff --git a/...ions-javadoc/src/main/java/io/qameta/allure/description/JavaDocDescriptionsProcessor.java b/...ions-javadoc/src/main/java/io/qameta/allure/description/JavaDocDescriptionsProcessor.java
@@ -76,10 +76,7 @@ public boolean process(final Set<? extends TypeElement> annotations, final Round
         final Set<ExecutableElement> methods = ElementFilter.methodsIn(elements);
         methods.forEach(method -> {
             final String rawDocs = elementUtils.getDocComment(method);
-            final List<String> typeParams = method.getParameters().stream()
-                    .map(this::methodParameterTypeMapper)
-                    .collect(Collectors.toList());
-            final String name = method.getSimpleName().toString();
+
             if (rawDocs == null) {
                 return;
             }
@@ -89,7 +86,14 @@ public boolean process(final Set<? extends TypeElement> annotations, final Round
                 return;
             }
 
-            final String hash = generateMethodSignatureHash(method.getEnclosingElement().toString(), name, typeParams);
+            final String name = method.getSimpleName().toString();
+            final List<String> typeParams = method.getParameters().stream()
+                    .map(this::methodParameterTypeMapper)
+                    .collect(Collectors.toList());
+
+            final String hash = generateMethodSignatureHash(
+                    method.getEnclosingElement().toString(), name, typeParams
+            );
             try {
                 final FileObject file = filer.createResource(StandardLocation.CLASS_OUTPUT, "",
                         ALLURE_DESCRIPTIONS_FOLDER + hash);

diff --git a/allure-junit4/src/main/java/io/qameta/allure/junit4/AllureJunit4.java b/allure-junit4/src/main/java/io/qameta/allure/junit4/AllureJunit4.java
@@ -180,6 +180,7 @@ private Optional<String> getDisplayName(final Description result) {
                 .map(DisplayName::value);
     }
 
+    @SuppressWarnings("PMD.AvoidLiteralsInIfCondition")
     private Optional<String> getDescription(final Description result) {
         final io.qameta.allure.Description annotation = result
                 .getAnnotation(io.qameta.allure.Description.class);