Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[allure-jsonunit] Deprecate AllureConfigurableJsonMatcher in favor of ConfigurableJsonMatcher #1060

Merged
merged 1 commit into from
Jul 5, 2024
Merged

[allure-jsonunit] Deprecate AllureConfigurableJsonMatcher in favor of ConfigurableJsonMatcher #1060

merged 1 commit into from
Jul 5, 2024

Conversation

valfirst
Copy link
Contributor

Context

No reason to keep custom interface when json-unit provides public one

Checklist

@valfirst valfirst changed the title [allure-jsonunit] Deprecate AllureConfigurableJsonMatcher.java in favor of ConfigurableJsonMatcher [allure-jsonunit] Deprecate AllureConfigurableJsonMatcher in favor of ConfigurableJsonMatcher Jun 27, 2024
@baev baev added the type:improvement Change that improves some user experience but can't be considered as a new feature label Jul 5, 2024
@baev baev merged commit 5649230 into allure-framework:main Jul 5, 2024
4 of 5 checks passed
@baev
Copy link
Member

baev commented Jul 5, 2024

@valfirst thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baev baev baev approved these changes

Assignees
No one assigned
Labels
theme:jsonunit type:improvement Change that improves some user experience but can't be considered as a new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@valfirst @baev