Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove uuid dependency #561

Merged
merged 1 commit into from
Aug 20, 2024
Merged

Remove uuid dependency #561

merged 1 commit into from
Aug 20, 2024

Conversation

kpumuk
Copy link
Contributor

@kpumuk kpumuk commented Aug 19, 2024

Why

The uuid gem is archived on GitHub since Jan 1, 2024: https://github.com/assaf/uuid

Although one might consider it feature complete and no longer require any updates (in fact, the last update was made 5 years ago), I would still consider it a risk. Its transitive dependencies macaddr and systemu were updated in 2019 and 2015 respectively.

The change removes 3 dependencies: uuid » macaddr » systemu.

How

Ruby already has a way to generate UUIDs via SecureRandom. It is v4 (compared to v1 implemented by the uuid gem), but for Allure purposes it should make no difference. Another option is PRNG version implemented in Random#uuid_v4 and Random#uuid_v7, but it requires an instance of PRNG, and so more code changes.

@CLAassistant
Copy link

CLAassistant commented Aug 19, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

codeclimate bot commented Aug 20, 2024

Code Climate has analyzed commit 14e5af4 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (80% is the threshold).

This pull request will bring the total coverage in the repository to 98.9% (0.0% change).

View more on Code Climate.

@kpumuk
Copy link
Contributor Author

kpumuk commented Aug 20, 2024

I probably can't do much about the CI failure

Your credentials were not found. To set up Application Default Credentials for your environment, see https://cloud.google.com/docs/authentication/external/set-up-adc

@andrcuns
Copy link
Collaborator

Makes perfect sense, less dependencies is always good 👍

CI failure is not critical, it couldn't upload the report, not a big deal.

@andrcuns andrcuns merged commit 7ccf409 into allure-framework:master Aug 20, 2024
12 of 13 checks passed
@andrcuns andrcuns added the enhancement Improvement or request label Aug 20, 2024
@kpumuk
Copy link
Contributor Author

kpumuk commented Aug 20, 2024

Thanks!

@kpumuk kpumuk deleted the uuid branch August 20, 2024 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants