Merge pull request #21 from alma/feature/ecom-2262-home-maison-error-…

…sylius Fix cart builder for product without image
alma · Dec 13, 2024 · 22d1d2f · 22d1d2f
2 parents d1394a1 + a5ac041
commit 22d1d2f
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,10 @@
 # Changelog
 
+v2.1.0
+------
+
+- Fix: CartBuilder fix call to member function getPath() on null
+
 v2.0.0
 ------
 

diff --git a/composer.json b/composer.json
@@ -1,6 +1,7 @@
 {
   "name": "alma/sylius-payment-plugin",
   "type": "sylius-plugin",
+  "version": "2.1.0",
   "keywords": [
     "alma",
     "buy now pay later",

diff --git a/src/AlmaSyliusPaymentPlugin.php b/src/AlmaSyliusPaymentPlugin.php
@@ -11,7 +11,7 @@
 
 final class AlmaSyliusPaymentPlugin extends Bundle
 {
-    const VERSION = "2.0.0";
+    const VERSION = "2.1.0";
 
     use SyliusPluginTrait;
 

diff --git a/src/DataBuilder/CartDataBuilder.php b/src/DataBuilder/CartDataBuilder.php
@@ -158,9 +158,9 @@ private function getProductPictureUrl(ProductVariantInterface $variant): string
         /** @var ImageInterface[] $images */
         $images = $subject->getImages();
 
-        if (count($mainPictures) > 0) {
+        if (!empty($mainPictures) && $mainPictures[0] !== null ) {
             $path = $mainPictures[0]->getPath();
-        } elseif (count($images) > 0) {
+        } elseif (!empty($images) && $images[0] !== null) {
             $path = $images[0]->getPath();
         }