-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add hmac verification on ipn #18
Closed
joyet-simon
wants to merge
6
commits into
develop
from
feature/ecom-1822-sylius-add-hmac-verification-on-ipn
Closed
Add hmac verification on ipn #18
joyet-simon
wants to merge
6
commits into
develop
from
feature/ecom-1822-sylius-add-hmac-verification-on-ipn
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FranceBe
reviewed
Sep 30, 2024
joyet-simon
changed the title
Feature/ecom 1822 sylius add hmac verification on ipn
Add hmac verification on ipn
Oct 1, 2024
Benjamin-Freoua-Alma
requested changes
Oct 3, 2024
Francois-Gomis
requested changes
Oct 7, 2024
Francois-Gomis
requested changes
Oct 7, 2024
Benjamin-Freoua-Alma
requested review from
Benjamin-Freoua-Alma and
Francois-Gomis
October 8, 2024 15:34
Benjamin-Freoua-Alma
approved these changes
Oct 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Without QA Test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for change
Linear task
Need to implement HMAC verification for IPN
Code changes
We add a SecurityHelper, a new AlmaException and a SecurityException.
In the SecurityHelper, we use the php client's function to make a verification on the signature.
We call this helper's function in the notify action (=IPN) and we throw exception when it's necessary.
How to test
As a reviewer, you are encouraged to test the PR locally.
Try to make a payment on the QA ENV, leave the Alma checkout before the return on the success page to get IPN call. Check on Datadog if everything is fine.
You can use POSTMAN to make a call with no signature or a bad signature.
Checklist for authors and reviewers
Non applicable