Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DEVX] Check latest release if no release draft to be published #544

Conversation

carine-bonnafous
Copy link
Contributor

@carine-bonnafous carine-bonnafous commented Jul 30, 2024

Reason for change

ECOM integrations team is likely to update the release draft body before publishing it as it is targeted to a public audience.
When updating it, it is easy to click on the big flashy button "Publish release" instead of the grey button "Save draft"
This cannot be undone from the UI, and this shouldn't make the release-publish workflow fail

Code changes

  • Update release-publish workflow : If no release draft is found, fetch the latest release and go on with it if the version matches
  • Update release/hotfix PR checklist: Add a warning to avoid misclick (even if handled, it is best not to publish the release before it is ready)

Copy link

sonarcloud bot commented Jul 30, 2024

@carine-bonnafous carine-bonnafous marked this pull request as ready for review July 30, 2024 14:19
@carine-bonnafous carine-bonnafous requested a review from a team as a code owner July 30, 2024 14:19
Copy link

⏳E2E tests are currently running.
➡️ You can follow their progression here.

Copy link

❌ E2E tests have failed.
➡️ You can find the results here.

@Benjamin-Freoua-Alma
Copy link
Member

Need to be reviewed by @alma/squad-devx 🙏

@hyahiaoui hyahiaoui merged commit 1581cc4 into main Aug 22, 2024
5 of 6 checks passed
@hyahiaoui hyahiaoui deleted the devx/handle-release-published-manually-prior-to-publish-workflow branch August 22, 2024 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants