-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DEVX] Check latest release if no release draft to be published #544
Merged
hyahiaoui
merged 2 commits into
main
from
devx/handle-release-published-manually-prior-to-publish-workflow
Aug 22, 2024
Merged
[DEVX] Check latest release if no release draft to be published #544
hyahiaoui
merged 2 commits into
main
from
devx/handle-release-published-manually-prior-to-publish-workflow
Aug 22, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Quality Gate passedIssues Measures |
⏳E2E tests are currently running. |
❌ E2E tests have failed. |
Benjamin-Freoua-Alma
approved these changes
Aug 1, 2024
Need to be reviewed by @alma/squad-devx 🙏 |
hyahiaoui
approved these changes
Aug 22, 2024
hyahiaoui
deleted the
devx/handle-release-published-manually-prior-to-publish-workflow
branch
August 22, 2024 10:28
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for change
ECOM integrations team is likely to update the release draft body before publishing it as it is targeted to a public audience.
When updating it, it is easy to click on the big flashy button "Publish release" instead of the grey button "Save draft"
This cannot be undone from the UI, and this shouldn't make the release-publish workflow fail
Code changes