Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v4.4.0 #578

Merged
merged 62 commits into from
Oct 7, 2024
Merged
Changes from 1 commit
Commits
Show all changes
62 commits
Select commit Hold shift + click to select a range
228a338
chore(deps): update pre-commit repositories
alma-renovate-bot[bot] Aug 12, 2024
0949007
Merge pull request #560 from alma/chore/backport-main-to-develop
Benjamin-Freoua-Alma Aug 12, 2024
c22f3b3
Merge pull request #559 from alma/renovate/pre-commit-repositories
Benjamin-Freoua-Alma Aug 12, 2024
2cd681e
feat: test to log Header IPN
Benjamin-Freoua-Alma Aug 13, 2024
193b1e9
feat: remove SoC log add IPN log
Benjamin-Freoua-Alma Aug 13, 2024
d811486
test(fix): update unknown namespace in unit test
FranceBe Aug 16, 2024
ad5de72
test(report): add coverage report in HTML
FranceBe Aug 16, 2024
5230bf9
chore(class): create dedicated class for custom error handling to gen…
FranceBe Aug 16, 2024
ab5a194
Merge pull request #562 from alma/chore/add-html-coverage-report
FranceBe Aug 26, 2024
df6ef78
chore(deps): update pre-commit hook returntocorp/semgrep to v1.86.0
alma-renovate-bot[bot] Sep 9, 2024
e854f0a
feat: WIP Hmac
Benjamin-Freoua-Alma Sep 9, 2024
4156082
chore(deps): update github actions (#564)
alma-renovate-bot[bot] Sep 9, 2024
83614c8
Merge pull request #563 from alma/renovate/pre-commit-repositories
Benjamin-Freoua-Alma Sep 11, 2024
a5c2774
fix: install module if container of getService Ps_account is null
Benjamin-Freoua-Alma Sep 13, 2024
1cda5b7
fix: Inpage on prestashop 1.6 with third party module of checkout
Benjamin-Freoua-Alma Sep 13, 2024
cafd35a
Merge pull request #566 from alma/fix/ecom-2057-ps-fix-inpage-on-pres…
Benjamin-Freoua-Alma Sep 16, 2024
d09496c
fix: review [FRA]
Benjamin-Freoua-Alma Sep 16, 2024
ae4d78a
chore(deps): update pre-commit hook returntocorp/semgrep to v1.87.0
alma-renovate-bot[bot] Sep 16, 2024
4fc6808
fix: check if key templateVars exist
Benjamin-Freoua-Alma Sep 16, 2024
5a59c00
fix: review [FRA] refacto check compatibility Ps Account
Benjamin-Freoua-Alma Sep 16, 2024
3e8f8ed
feat: set our product detail in our template
Benjamin-Freoua-Alma Sep 16, 2024
98f9c0f
Merge pull request #567 from alma/renovate/pre-commit-repositories
Benjamin-Freoua-Alma Sep 17, 2024
3cb1d11
feat: add HMAC Payment Validation Prestashop
Benjamin-Freoua-Alma Sep 17, 2024
9c1692e
fix: remove condition to display insurance widget if layout is not empty
Benjamin-Freoua-Alma Sep 17, 2024
c9256c6
fix: add verification in insurance js if add to cart button doesn't e…
Benjamin-Freoua-Alma Sep 17, 2024
38a838f
fix: event add to cart for insurance if add to cart button isn't defa…
Benjamin-Freoua-Alma Sep 17, 2024
48dda19
fix: add verification in insurance js if add to cart button doesn't e…
Benjamin-Freoua-Alma Sep 17, 2024
34c3cc1
fix: review [FRA] alias not needed
Benjamin-Freoua-Alma Sep 18, 2024
e4d74b0
fix: review [FRA] function to get addToCart
Benjamin-Freoua-Alma Sep 18, 2024
1d95d6b
Merge pull request #565 from alma/fix/ecom-2056-ps-fix-install-module…
Benjamin-Freoua-Alma Sep 18, 2024
acee6c0
feat: review [FRA] replace let to const for addToCart variable
Benjamin-Freoua-Alma Sep 18, 2024
1b856f5
feat: review [FRA]
Benjamin-Freoua-Alma Sep 18, 2024
c418043
Merge pull request #568 from alma/feature/ecom-2062-ps-fix-insurance-…
Benjamin-Freoua-Alma Sep 18, 2024
3b1a65a
feat: review [FRA]
Benjamin-Freoua-Alma Sep 19, 2024
831d45c
chore(naming): rename function to be clearer
FranceBe Sep 25, 2024
38454b8
Merge pull request #561 from alma/feature/ecom-1818-ps-add-hmac-verif…
Benjamin-Freoua-Alma Sep 25, 2024
ea78820
feat: Change state insurance product according insurance config state
Benjamin-Freoua-Alma Sep 18, 2024
e37cfd0
Merge pull request #571 from alma/chore/rename-variable
Benjamin-Freoua-Alma Sep 30, 2024
2cf9974
feat: add hmac verification on ipn
joyet-simon Oct 1, 2024
d951d30
fix: setContainer Ps Account install module
Benjamin-Freoua-Alma Oct 1, 2024
ae2939e
Merge pull request #569 from alma/feature/ecom-2003-ps-remove-insuran…
Benjamin-Freoua-Alma Oct 1, 2024
6260062
Merge pull request #575 from alma/feature/ecom-2070-ps-integrate-cred…
joyet-simon Oct 1, 2024
f6e32f5
Merge pull request #576 from alma/fix/ecom-2112-ps-fix-setcontainer-p…
Benjamin-Freoua-Alma Oct 1, 2024
2071c24
fix: paymentValidation in validation controller since HMAC
Benjamin-Freoua-Alma Sep 26, 2024
c66099c
fix: unit test
Benjamin-Freoua-Alma Sep 26, 2024
21672bb
fix: Review [MAR] renaming
Benjamin-Freoua-Alma Sep 27, 2024
3b0bbe2
fix: HMAC get the right APIKey
Benjamin-Freoua-Alma Sep 30, 2024
8ecbbcd
fix: add verification if header X-Alma-Signature doesn't exist
Benjamin-Freoua-Alma Oct 1, 2024
add5006
fix: automatique height insurance widget
Benjamin-Freoua-Alma Sep 26, 2024
d5b95e3
fix: WIP handle height widget insurance + Need to refresh productDeta…
Benjamin-Freoua-Alma Sep 26, 2024
0a196d1
fix: refresh data from productDetails + get button add-to-cart Ravate
Benjamin-Freoua-Alma Oct 1, 2024
9db8cd3
fix: refresh data widget after change product reference
Benjamin-Freoua-Alma Oct 1, 2024
84d178e
fix: change remove insurance product with product since ps 1.7.1
Benjamin-Freoua-Alma Oct 1, 2024
63bdef3
Merge pull request #573 from alma/fix/ecom-2102-ps-fix-paymentvalidat…
Benjamin-Freoua-Alma Oct 2, 2024
3359a85
fix: change data widget on change reference
Benjamin-Freoua-Alma Oct 2, 2024
4322c41
Merge pull request #572 from alma/fix/ecom-2095-ps-fix-handle-height-…
Benjamin-Freoua-Alma Oct 2, 2024
a463a2f
fix: display widget on PS 1.7.0.6
Benjamin-Freoua-Alma Oct 2, 2024
83cdf64
Merge pull request #577 from alma/fix/ecom-2113-ps-fix-display-widget…
Benjamin-Freoua-Alma Oct 2, 2024
0bb45da
chore: update version
Benjamin-Freoua-Alma Oct 7, 2024
0109d9a
chore: update translation
Benjamin-Freoua-Alma Oct 7, 2024
7f1e8bb
fix: Review [FRA]
Benjamin-Freoua-Alma Oct 7, 2024
78cdb51
fix: Review [FRA]
Benjamin-Freoua-Alma Oct 7, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: review [FRA] function to get addToCart
Benjamin-Freoua-Alma committed Sep 18, 2024
commit e4d74b043048cc71d18632a61c8f0c24656b83ca
15 changes: 11 additions & 4 deletions alma/views/js/alma-product-insurance.js
Original file line number Diff line number Diff line change
@@ -245,17 +245,24 @@ function removeInputInsurance() {

function addModalListenerToAddToCart() {
if (settings.isAddToCartPopupActivated === true && almaEligibilityAnswer) {
let addToCart = document.querySelector('.add-to-cart');
if (!addToCart) {
addToCart = document.querySelector('.add-to-cart a, .add-to-cart button');
}
let addToCart = getAddToCartButton();
if (addToCart) {
// If we change the quantity the DOM is reloaded then we need to remove and add the listener again
addToCart.removeEventListener("click", insuranceListener);
addToCart.addEventListener("click", insuranceListener);
}
}
}

function getAddToCartButton() {
let addToCart = document.querySelector('.add-to-cart');
if (!addToCart) {
addToCart = document.querySelector('.add-to-cart a, .add-to-cart button');
}

return addToCart;
}

function insuranceListener(event) {
if (!insuranceSelected) {
event.preventDefault();