-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release v4.5.0 #600
Closed
Closed
Release v4.5.0 #600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Backport main to develop
chore(deps): update github actions
…ge-to-fix-incompatibilities feat: add inpage setting for selector payment buttons
…s-5.x chore(deps): update pre-commit hook pre-commit/pre-commit-hooks to v5
Co-authored-by: alma-renovate-bot[bot] <163289924+alma-renovate-bot[bot]@users.noreply.github.com>
chore(deps): update pre-commit hook returntocorp/semgrep to v1.92.0
Instead of trying to find it from the DOM + use plain JS objects instead of data attributes for settings & product details
There's a bug in some PS 1.7 versions where quantity_wanted is not set to the actual quantity value
Fix insurance widget conflict with product details panel
Some versions of PS (e.g. 1.7.2.4) will completely reload the product actions DOM, causing the widget to fully reload and loose its state. As a result, the insurance modal always uses a quantity=1 when opened via the widget. Including the quantity in the URL fixes that
PrestaShop events are not manually triggered anymore, as we really only need to listen to them, so that we can trigger some update flows. The rest of the control flow remains handled at the message event handler level, which removes unnecessary reloads and fixes a few other bugs
chore(deps): update pre-commit repositories
chore(deps): update mysql docker tag to v9.1
Improve insurance integration stability & prevent unnecessary reloading of widget
Backport main to develop
…-for-in-page-advanced-feature feat: Update wording for In-Page advanced feature
chore(deps): update pre-commit hook returntocorp/semgrep to v1.95.0
…-english-in-the-checkout-module fix: issue with some translation in payment buttons
chore(deps): update pre-commit repositories
Prevent crash when there is not quantity input on product page
alma-create-pr-with-team-review
bot
requested a review
from a team
as a code owner
November 13, 2024 09:15
alma-create-pr-with-team-review
bot
requested a review
from a team
as a code owner
November 13, 2024 09:15
⏳E2E tests are currently running. |
Quality Gate failedFailed conditions See analysis details on SonarQube Cloud Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE |
wrong version number |
❌ E2E tests have failed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update version to v4.5.0
Checklist of actions to be done before merging
Save draft
to update it, do not click onPublish release
: it will be published automatically after the merge of this PR