Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/pre commit #647

Merged
merged 7 commits into from
Feb 18, 2025
Merged

Fix/pre commit #647

merged 7 commits into from
Feb 18, 2025

Conversation

webaaz
Copy link
Member

@webaaz webaaz commented Feb 14, 2025

Reason for change

For now pre-commit hook works locally, and it's a pain to change PHP version each time we need composer or phpcs.

PHPCS should work into a docker container, we don't need PHP locally.

Linear task

Code changes

Dockerfiles

How to test

As a reviewer, you are encouraged to test the PR locally.

You can test pre-commit hook

Checklist for authors and reviewers

  • The title of the PR uses business wording, not technical jargon, for the changelog readers to understand it
  • The PR implements the changes asked in the referenced task / issue
  • The automated tests are compliant with the testing strategy
  • The tests are relevant, and cover the corner/error cases, not only the happy path
  • You understand the impact of this PR on existing code/features
  • The changes include adequate logging and Datadog traces
  • Documentation is updated (API, developer documentation, ADR, Notion...)

Non applicable

Now phpcs is launched into a dockerfile
@webaaz webaaz requested review from a team as code owners February 14, 2025 08:16
@github-actions github-actions bot added the type: bugfix Bug fix label Feb 14, 2025

This comment has been minimized.

@webaaz webaaz changed the base branch from main to develop February 14, 2025 08:16

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
1 Security Hotspot

See analysis details on SonarQube Cloud

Copy link

⏳E2E tests are currently running.
➡️ You can follow their progression here.

Copy link

❌ E2E tests have failed.
➡️ You can find the results here.

Copy link

❌ E2E tests have failed.
➡️ You can find the results here.

Copy link
Collaborator

@Francois-Gomis Francois-Gomis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That work

@Francois-Gomis Francois-Gomis self-requested a review February 18, 2025 10:41
@webaaz webaaz merged commit 27c7b2d into develop Feb 18, 2025
4 of 6 checks passed
@webaaz webaaz deleted the fix/pre-commit branch February 18, 2025 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants