Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Error in payment return when the order payment was not retrieved #658

Conversation

Benjamin-Freoua-Alma
Copy link
Member

Reason for change

Linear task

Code changes

How to test

As a reviewer, you are encouraged to test the PR locally.

Test in the merchant env. Tu reproduce the test, you need to throw Exception in the function getOrderPayment() in OrderHelper Class and create a full payment with the return page.

Checklist for authors and reviewers

  • The title of the PR uses business wording, not technical jargon, for the changelog readers to understand it
  • The PR implements the changes asked in the referenced task / issue
  • You understand the impact of this PR on existing code/features
  • The changes include adequate logging and Datadog traces
  • Documentation is updated (API, developer documentation, ADR, Notion...)

Non applicable

  • The automated tests are compliant with the testing strategy
  • The tests are relevant, and cover the corner/error cases, not only the happy path

@Benjamin-Freoua-Alma Benjamin-Freoua-Alma self-assigned this Feb 24, 2025
@Benjamin-Freoua-Alma Benjamin-Freoua-Alma requested a review from a team as a code owner February 24, 2025 13:17
@github-actions github-actions bot added the type: bugfix Bug fix label Feb 24, 2025

This comment has been minimized.

This comment has been minimized.

1 similar comment

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link

⏳E2E tests are currently running.
➡️ You can follow their progression here.

Copy link

❌ E2E tests have failed.
➡️ You can find the results here.

@Benjamin-Freoua-Alma Benjamin-Freoua-Alma merged commit f702223 into develop Feb 25, 2025
5 of 6 checks passed
@Benjamin-Freoua-Alma Benjamin-Freoua-Alma deleted the fix/ecom-2501-garboche-payment-creation-error-logs branch February 25, 2025 16:45
Copy link

❌ E2E tests have failed.
➡️ You can find the results here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants