Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/fetch payment #14

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Feat/fetch payment #14

wants to merge 2 commits into from

Conversation

olance
Copy link
Contributor

@olance olance commented Mar 4, 2022

Adds the payment fetch API endpoint to the client

@olance olance requested review from Taskim and cnerot March 4, 2022 14:18
@sonarcloud
Copy link

sonarcloud bot commented Mar 4, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Taskim
Taskim approved these changes Mar 10, 2022
View reviewed changes
test/endpoints/payments.test.ts
Comment on lines +6 to +10
import Request from '../../src/http/request'
import * as RequestModule from '../../src/http/request'
import Response from '../../src/http/response'
import MerchantIdCredentials from '../../src/credentials/MerchantIdCredentials'
import { ApiMode } from '../../src'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you could use absolute imports

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Taskim Taskim Taskim approved these changes

@cnerot cnerot Awaiting requested review from cnerot

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@olance @Taskim