Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add code coverage github action #73

Merged
merged 2 commits into from
Feb 6, 2024

Conversation

joyet-simon
Copy link
Contributor

@joyet-simon joyet-simon commented Feb 2, 2024

Reason for change

Linear task

We want to improve our quality code.

Code changes

We add a github action to check the code coverage and block PR if it not respect our standards.

How to test

As a reviewer, you are encouraged to test the PR locally.

Checklist for authors and reviewers

  • The title of the PR uses business wording, not technical jargon, for the changelog readers to understand it
  • The PR implements the changes asked in the referenced task / issue
  • The automated tests are compliant with the testing strategy
  • The tests are relevant, and cover the corner/error cases, not only the happy path
  • You understand the impact of this PR on existing code/features
  • The changes include adequate logging and Datadog traces
  • Documentation is updated (API, developer documentation, ADR, Notion...)

Non applicable

@joyet-simon joyet-simon self-assigned this Feb 2, 2024
@joyet-simon joyet-simon force-pushed the feature/ecom-1284-add-code-coverage branch from 596c000 to 0a80373 Compare February 5, 2024 15:32
@joyet-simon joyet-simon changed the title add code coverage github action Add code coverage github action Feb 5, 2024
@joyet-simon joyet-simon marked this pull request as ready for review February 5, 2024 15:36
.github/workflows/code-coverage.yaml Outdated Show resolved Hide resolved
.github/workflows/code-coverage.yaml Outdated Show resolved Hide resolved
Copy link

sonarqubecloud bot commented Feb 5, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@joyet-simon joyet-simon requested a review from gdraynz February 5, 2024 16:11
@joyet-simon joyet-simon merged commit 96153eb into develop Feb 6, 2024
2 checks passed
@joyet-simon joyet-simon deleted the feature/ecom-1284-add-code-coverage branch February 6, 2024 14:53
@Benjamin-Freoua-Alma Benjamin-Freoua-Alma mentioned this pull request Feb 6, 2024
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants