Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add order id in subscription model and call to api #84

Conversation

Benjamin-Freoua-Alma
Copy link
Member

Reason for change

ClickUp task

Code changes

How to test

As a reviewer, you are encouraged to test the PR locally.

Checklist for authors and reviewers

  • The title of the PR uses business wording, not technical jargon, for the changelog readers to understand it
  • The PR implements the changes asked in the referenced task / issue
  • The automated tests are compliant with the testing strategy
  • The tests are relevant, and cover the corner/error cases, not only the happy path
  • You understand the impact of this PR on existing code/features
  • The changes include adequate logging and Datadog traces
  • Documentation is updated (API, developer documentation, ADR, Notion...)

Non applicable

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
57.1% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@Benjamin-Freoua-Alma Benjamin-Freoua-Alma merged commit da2514d into develop Feb 14, 2024
2 of 3 checks passed
@Benjamin-Freoua-Alma Benjamin-Freoua-Alma deleted the feature/ecom-1347-add-order_id-in-subscription-model-and-call-to-api branch February 14, 2024 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants