Coverage report #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The states that deploy Pods can be consolidated with a single interface for GetManifestObjects function. Making this interface public allows us to render manifests outside of reconcile loop to extract meta-info for validation and coverage checks Signed-off-by: amaslennikov <[email protected]>
Validate container names in admission webhook Signed-off-by: amaslennikov <[email protected]>
Add webhook validation for: - Container names used in resource requirements - Resource requests should not exceed limits - Requirements should not be zero - Requirements should not be empty if declared
Signed-off-by: amaslennikov <[email protected]>
Signed-off-by: amaslennikov <[email protected]>
Signed-off-by: amaslennikov <[email protected]>
This test renders all manifests to extract deployable containers' names and parses values.yaml from the helm chart to make sure that all containers are represented in the helm chart under the ResourceRequirements section Signed-off-by: amaslennikov <[email protected]>
Update README Add continuity check unit test: * This test renders all manifests to extract deployable containers' names and parses values.yaml from the helm chart to make sure that all containers are represented in the helm chart under the ResourceRequirements section
Bump controller-tools from v0.10.0 to v0.13.0. No major changes, just some bug fixes - e.g. `creationTimestamp` is no longer rendered as `null` in CRDs. Release notes: https://github.com/kubernetes-sigs/controller-tools/releases/tag/v0.13.0 https://github.com/kubernetes-sigs/controller-tools/releases/tag/v0.12.0 https://github.com/kubernetes-sigs/controller-tools/releases/tag/v0.11.0
Add support to configure operator resources in the Helm templating. Fixes Mellanox#722 Signed-off-by: Fred Rolland <[email protected]>
Add support to configure operator resources in the Helm templating. Fixes Mellanox#722
Signed-off-by: Fred Rolland <[email protected]>
Signed-off-by: Vasilis Remmas <[email protected]>
Update Helm README with `useCDI`
We already have a label which marks a pod as a driver pod which does not rely on the version of the driver. use it instead Signed-off-by: adrianc <[email protected]>
- Fix the title to contain the right state name - Add a note about safeLoad annotation Signed-off-by: Yury Kulazhenkov <[email protected]>
Always set CREATE_IFNAME_UDEV to true env var as recent mofed driver container performs a more robust logic to preserve netev interface names via udev. Signed-off-by: adrianc <[email protected]>
…ellanox#730) - Fix the title to contain the right state name - Add a note about safeLoad annotation
change default driver container to doca-driver this container provides same functionality but is part of the doca host software suite Signed-off-by: adrianc <[email protected]>
run make `release-build` Signed-off-by: adrianc <[email protected]>
We already have a label which marks a pod as a driver pod which does not rely on the version of the driver. use it instead
Signed-off-by: killianmuldoon <[email protected]>
Update the `setup-envtest` version and Kubernetes version for envtest used in the Makefile. A couple of other small cleanups - removing broken `test-xml` make target and unused `tools.go` file.
In Openshift, in order to OFED containter to be able to download and compile the needed Kernel files, it is required to install a cluster-wide entitlement. This requirement is not user friendly. In order to avoid this, a container image with the needed files is available in Openshift distributions. This image is called DriverToolKit aka DTK. By using this container as a side-car to MOFED container, the modules can be compiled without entitlement. Changes: API: - DTK is 'true' by default, and can be changed by env variable in the Operator Deployment OFED state: - In case of OCP and 'useOcpDriverToolkit' is true, find DTK image based on NFD label of node. - If available, add to MOFED DS a DTK container, change entrypoint logic. Signed-off-by: Fred Rolland <[email protected]>
change default driver container to doca-driver this container provides same functionality but is part of the doca host software suite
- update version - update mounts to accomodate new udev rule in mofed Signed-off-by: adrianc <[email protected]>
Always set CREATE_IFNAME_UDEV to true env var as recent mofed driver container performs a more robust logic to preserve netev interface names via udev.
Signed-off-by: adrianc <[email protected]>
When deploying network-operator helm chart, the templates rely on chart.AppVersion when constructing the image url. To allow to automate chart publishing, consistent AppVersions need to be provided when chart is built. Add a flag to helm package command in the make chart-build target Signed-off-by: amaslennikov <[email protected]>
…Mellanox#709) Today it's cumbersome to enable admission controllers for SRIOV Network Operator because the user needs to create a secret manually. With this PR k8snetworkplumbingwg/sriov-network-operator#561, it's possible to generate a self signed certificate so the user doesn't need to do manual steps to enable those admission controllers. This PR just updates the chart to the latest chart found in the `master` branch of https://github.com/k8snetworkplumbingwg/sriov-network-operator which at the time was k8snetworkplumbingwg/sriov-network-operator@233b99a. Another PR will enable proper support for admission controllers.
The helm repository alias (_mellanox_) and URL (`https://mellanox.github.io/network-operator`) was outdated in the network-operator documentation. This commit corrects it to use the up-to-date alias (_nvidia_) and URL (`https://helm.ngc.nvidia.com/nvidia`). The issue may exist in other locations (repositories), but this is the "main" one.
Bumps [github.com/onsi/ginkgo/v2](https://github.com/onsi/ginkgo) from 2.17.0 to 2.17.1. - [Release notes](https://github.com/onsi/ginkgo/releases) - [Changelog](https://github.com/onsi/ginkgo/blob/master/CHANGELOG.md) - [Commits](onsi/ginkgo@v2.17.0...v2.17.1) --- updated-dependencies: - dependency-name: github.com/onsi/ginkgo/v2 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
…#873) Bumps [github.com/onsi/ginkgo/v2](https://github.com/onsi/ginkgo) from 2.17.0 to 2.17.1. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/onsi/ginkgo/releases">github.com/onsi/ginkgo/v2's releases</a>.</em></p> <blockquote> <h2>v2.17.1</h2> <h2>2.17.1</h2> <h3>Fixes</h3> <ul> <li>If the user sets --seed=0, make sure all parallel nodes get the same seed [af0330d]</li> </ul> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/onsi/ginkgo/blob/master/CHANGELOG.md">github.com/onsi/ginkgo/v2's changelog</a>.</em></p> <blockquote> <h2>2.17.1</h2> <h3>Fixes</h3> <ul> <li>If the user sets --seed=0, make sure all parallel nodes get the same seed [af0330d]</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/onsi/ginkgo/commit/92423385b96b8be0ac6c4686ff305f30f885e59e"><code>9242338</code></a> v2.17.1</li> <li><a href="https://github.com/onsi/ginkgo/commit/af0330d31fa540b51756c14daf6b1c55515a379c"><code>af0330d</code></a> If the user sets --seed=0, make sure all parallel nodes get the same seed</li> <li>See full diff in <a href="https://github.com/onsi/ginkgo/compare/v2.17.0...v2.17.1">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details>
Signed-off-by: Fred Rolland <[email protected]>
Examples are available in official doc: https://docs.nvidia.com/networking/display/kubernetes2410/getting+started+with+kubernetes
Signed-off-by: Fred Rolland <[email protected]>
Signed-off-by: nvidia-ci-cd <[email protected]>
Signed-off-by: Yury Kulazhenkov <[email protected]>
This version includes auto-bridge selection logic which is not yet merged to the upstream Signed-off-by: Yury Kulazhenkov <[email protected]>
Update chart for sriov-network-operator to match downstream version of sriov-network-operator \+ use downstream version of ovs-cni
Signed-off-by: nvidia-ci-cd <[email protected]>
Signed-off-by: Yury Kulazhenkov <[email protected]>
Temporary workaround for CI issue Signed-off-by: Yury Kulazhenkov <[email protected]>
Temporary workaround for CI issue
Signed-off-by: amaslennikov <[email protected]>
Bumps [sigs.k8s.io/controller-runtime](https://github.com/kubernetes-sigs/controller-runtime) from 0.17.2 to 0.17.3. - [Release notes](https://github.com/kubernetes-sigs/controller-runtime/releases) - [Changelog](https://github.com/kubernetes-sigs/controller-runtime/blob/main/RELEASE.md) - [Commits](kubernetes-sigs/controller-runtime@v0.17.2...v0.17.3) --- updated-dependencies: - dependency-name: sigs.k8s.io/controller-runtime dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
…lanox#887) Bumps [sigs.k8s.io/controller-runtime](https://github.com/kubernetes-sigs/controller-runtime) from 0.17.2 to 0.17.3.
Upgrade to a new non-release version
Signed-off-by: Ivan Kolodiazhnyi <[email protected]>
…nox#890) Update SR-IOV Network Operator chart to deploy RDMA CNI
Signed-off-by: nvidia-ci-cd <[email protected]>
…tion-client Bumps [github.com/k8snetworkplumbingwg/network-attachment-definition-client](https://github.com/k8snetworkplumbingwg/network-attachment-definition-client) from 1.6.0 to 1.7.0. - [Release notes](https://github.com/k8snetworkplumbingwg/network-attachment-definition-client/releases) - [Commits](k8snetworkplumbingwg/network-attachment-definition-client@v1.6.0...v1.7.0) --- updated-dependencies: - dependency-name: github.com/k8snetworkplumbingwg/network-attachment-definition-client dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
…tion-client from 1.6.0 to 1.7.0 (Mellanox#894) Bumps [github.com/k8snetworkplumbingwg/network-attachment-definition-client](https://github.com/k8snetworkplumbingwg/network-attachment-definition-client) from 1.6.0 to 1.7.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/k8snetworkplumbingwg/network-attachment-definition-client/releases">github.com/k8snetworkplumbingwg/network-attachment-definition-client's releases</a>.</em></p> <blockquote> <h2>v1.7.0</h2> <p>Adds MTU to network-status</p> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/k8snetworkplumbingwg/network-attachment-definition-client/commit/8a8e914f94d96bc412215f123b4b693d5d32c1ee"><code>8a8e914</code></a> Merge pull request <a href="https://redirect.github.com/k8snetworkplumbingwg/network-attachment-definition-client/issues/65">#65</a> from SchSeba/support_mtu</li> <li><a href="https://github.com/k8snetworkplumbingwg/network-attachment-definition-client/commit/668df908324c17320aa546f9355e1eb6c3a8192f"><code>668df90</code></a> Support MTU representation in NetworkStatus</li> <li><a href="https://github.com/k8snetworkplumbingwg/network-attachment-definition-client/commit/fe19962870149ad58098d797595fc72d3a5c3e94"><code>fe19962</code></a> Merge pull request <a href="https://redirect.github.com/k8snetworkplumbingwg/network-attachment-definition-client/issues/64">#64</a> from k8snetworkplumbingwg/dependabot/go_modules/google...</li> <li><a href="https://github.com/k8snetworkplumbingwg/network-attachment-definition-client/commit/b469461fe8ea1593b218056f5372c0ad6006baff"><code>b469461</code></a> Bump google.golang.org/protobuf from 1.31.0 to 1.33.0</li> <li>See full diff in <a href="https://github.com/k8snetworkplumbingwg/network-attachment-definition-client/compare/v1.6.0...v1.7.0">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details>
Signed-off-by: amaslennikov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.