Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated access modifiers for easy sub-classing #65

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Updated access modifiers for easy sub-classing #65

wants to merge 2 commits into from

Conversation

Minitour
Copy link

@Minitour Minitour commented Dec 7, 2019

In order to allow sub-classing and easier access to customize the controller, I changed most access modifiers from public to open.

stephanboner
stephanboner approved these changes Jan 27, 2021
View reviewed changes
Copy link

@stephanboner stephanboner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like that and I think it is really convenient & improving the flexibility of the Picker so please merge!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephanboner stephanboner stephanboner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Minitour @stephanboner