Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update table-plugin.js #1142

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Conversation

cecilialam
Copy link
Contributor

This is related to Update port-helper-attribute-field.js #1141. I am adding a placeholder message to the Table Summary textbox on the toolbar.

This is related to Update port-helper-attribute-field.js alohaeditor#1141. I am adding a placeholder message to the Table Summary textbox on the toolbar.
@GenticsDev
Copy link
Contributor

test

@Jotschi
Copy link
Contributor

Jotschi commented Mar 26, 2014

!Test

@Jotschi
Copy link
Contributor

Jotschi commented Mar 26, 2014

@cecilialam
Hi,
we have some problems with our automated build triggering. I guess i screwed up the default message for our build bot. I updated it already.

@Jotschi
Copy link
Contributor

Jotschi commented Mar 26, 2014

!Test

@Jotschi
Copy link
Contributor

Jotschi commented Mar 26, 2014

test this please

@cecilialam
Copy link
Contributor Author

no problem.Thanks for your reply.

@GenticsDev
Copy link
Contributor

✔ Test passed.
Refer to this link for build results: http://jenkins.office:8080/job/alohaeditor-upstream-pullrequests/81/

@petrosalema
Copy link
Member

@cecilialam How does this work? Having the placedholder property added does not seem to cause any change for me.

@petrosalema
Copy link
Member

Ah.. I see. This goes together with this #1141 pull request. @cecilialam We should squash these two commits and land this change in a single pull request.

@petrosalema
Copy link
Member

Please also include a changelog file for this patch → http://www.alohaeditor.org/guides/develop_aloha.html#changelog.

@GenticsDev
Copy link
Contributor

Can one of the admins verify this patch?

1 similar comment
@GenticsDev
Copy link
Contributor

Can one of the admins verify this patch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants