Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Component schemas, missing endpoint and various fixes for Broker API spec #36

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

Component schemas, missing endpoint and various fixes for Broker API spec #36

wants to merge 12 commits into from

Conversation

manul7
Copy link

@manul7 manul7 commented Aug 23, 2022

Added new components schemas declaration for:

  • OathClientStatus
  • AssetStatus
  • BankAccountType
  • AchStatus
  • BankCodeType

Added missing endpoint for /v1/trading/accounts/{account_id}/orders:by_client_order_id

Added missing items for multiple enums and Contact component and fixed incorrect numbers declaration.

QA

  • Linter passes without issues and new warnings.
  • Validation passes without issues:
$ npm run validate broker/openapi.yaml 

> [email protected] validate
> swagger-cli validate

broker/openapi.yaml is valid

@manul7
Copy link
Author

manul7 commented Aug 24, 2022

@drew887 could you please take a look?

@drew887
Copy link
Contributor

drew887 commented Aug 24, 2022

@manul7 Sorry I no longer work for Alpaca, @haxdds or @gsmadi are the main points of contact now I believe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@manul7 @drew887