Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: move pagination logic for historical market data to the base rest client #525

Merged
merged 2 commits into from
Nov 14, 2024

Conversation

gnvk
Copy link
Contributor

@gnvk gnvk commented Nov 8, 2024

No description provided.

@gnvk gnvk requested a review from hiohiohio as a code owner November 8, 2024 08:19
Copy link
Contributor

@hiohiohio hiohiohio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM! Left small comments.

alpaca/common/rest.py Outdated Show resolved Hide resolved
alpaca/common/rest.py Outdated Show resolved Hide resolved
alpaca/common/rest.py Outdated Show resolved Hide resolved
tests/data/test_historical_stock_data.py Show resolved Hide resolved
alpaca/data/historical/stock.py Show resolved Hide resolved
Copy link
Contributor

@hiohiohio hiohiohio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@hiohiohio hiohiohio merged commit e6edb1e into master Nov 14, 2024
12 checks passed
@hiohiohio hiohiohio deleted the refactor-get-marketdata branch November 14, 2024 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants