Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move some constants to config #625

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

make broadcast poll duration configurable

2a8cb6d
Select commit
Loading
Failed to load commit list.
Draft

Move some constants to config #625

make broadcast poll duration configurable
2a8cb6d
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 21, 2025 in 0s

56.31% (-0.25%) compared to 38abd51

View this Pull Request on Codecov

56.31% (-0.25%) compared to 38abd51

Details

Codecov Report

Attention: Patch coverage is 37.64706% with 53 lines in your changes missing coverage. Please review.

Project coverage is 56.31%. Comparing base (38abd51) to head (2a8cb6d).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
bin/bridge-client/src/modes/operator/bootstrap.rs 0.00% 12 Missing ⚠️
crates/btcio/src/broadcaster/handle.rs 0.00% 10 Missing ⚠️
bin/strata-client/src/main.rs 0.00% 9 Missing ⚠️
bin/strata-client/src/args.rs 0.00% 8 Missing ⚠️
crates/config/src/btcio.rs 0.00% 5 Missing ⚠️
crates/btcio/src/rpc/client.rs 85.00% 3 Missing ⚠️
bin/prover-client/src/main.rs 0.00% 2 Missing ⚠️
bin/strata-client/src/helpers.rs 0.00% 2 Missing ⚠️
crates/btcio/src/broadcaster/task.rs 0.00% 2 Missing ⚠️ 
@@            Coverage Diff             @@
##             main     #625      +/-   ##
==========================================
- Coverage   56.56%   56.31%   -0.25%     
==========================================
  Files         313      316       +3     
  Lines       32634    32815     +181     
==========================================
+ Hits        18459    18481      +22     
- Misses      14175    14334     +159
Files with missing lines Coverage Δ
bin/bridge-client/src/args.rs 0.00% <ø> (ø)
bin/prover-client/src/args.rs 0.00% <ø> (ø)
crates/btcio/src/test_utils.rs 70.91% <100.00%> (ø)
crates/config/src/config.rs 95.91% <100.00%> (+0.26%) ⬆️
crates/util/python-utils/src/drt.rs 87.26% <100.00%> (+0.08%) ⬆️
bin/prover-client/src/main.rs 0.00% <0.00%> (ø)
bin/strata-client/src/helpers.rs 0.00% <0.00%> (ø)
crates/btcio/src/broadcaster/task.rs 87.46% <0.00%> (-0.23%) ⬇️
crates/btcio/src/rpc/client.rs 88.67% <85.00%> (+0.48%) ⬆️
crates/config/src/btcio.rs 70.58% <0.00%> (-29.42%) ⬇️
... and 4 more

... and 13 files with indirect coverage changes

View more details on Codecov