-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix sequencer crash tests #653
base: main
Are you sure you want to change the base?
Conversation
Commit: c869cd2 SP1 Performance Test Results
|
e60a03e
to
5e43408
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor nits and perhaps engine call could be reduced to a single call instead of log(n) calls. Also perhaps the print
s could be replaced with info
/debug
s. Looks good otherwise.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Something got really weird with the github review and some comments got submitted into multiple separate reviews without me intending to, quality software.
But the actual comment I wanted to make was that there's a few places here where the term idx
is being used in a way that could be vague. It would be better to use a more explicit term like slot
if possible.
5e43408
to
3b4bdf3
Compare
add test case for sync_event_new_tip crash fix for sync_event_new_tip crash testcase: construct fcm data from chainstate
enable crash_advance_consensus_state test
2962acc
to
a169b32
Compare
Description
Type of Change
Notes to Reviewers
Checklist
Related Issues