Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

datatool: generate evm genesishash and stateroot from chain config json #656

Merged
merged 1 commit into from
Feb 7, 2025

Conversation

sapinb
Copy link
Contributor

@sapinb sapinb commented Feb 6, 2025

Description

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature/Enhancement (non-breaking change which adds functionality or enhances an existing one)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactor
  • New or updated tests
  • Dependency Update

Notes to Reviewers

Checklist

  • I have performed a self-review of my code.
  • I have commented my code where necessary.
  • I have updated the documentation if needed.
  • My changes do not introduce new warnings.
  • I have added tests that prove my changes are effective or that my feature works.
  • New and existing tests pass with my changes.

Related Issues

@sapinb sapinb requested review from a team as code owners February 6, 2025 14:27
Copy link

codecov bot commented Feb 6, 2025

Codecov Report

Attention: Patch coverage is 0% with 20 lines in your changes missing coverage. Please review.

Project coverage is 54.66%. Comparing base (2830f20) to head (b2b448d).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
bin/datatool/src/util.rs 0.00% 20 Missing ⚠️
@@            Coverage Diff             @@
##             main     #656      +/-   ##
==========================================
- Coverage   54.68%   54.66%   -0.02%     
==========================================
  Files         314      314              
  Lines       33580    33590      +10     
==========================================
- Hits        18363    18362       -1     
- Misses      15217    15228      +11     
Files with missing lines Coverage Δ
bin/datatool/src/args.rs 0.00% <ø> (ø)
bin/datatool/src/util.rs 0.00% <0.00%> (ø)

... and 6 files with indirect coverage changes

Copy link
Contributor

github-actions bot commented Feb 6, 2025

Commit: 1b8d59b

SP1 Performance Test Results

program cycles success
BTC_BLOCKSPACE 30,370,673
EL_BLOCK 97,975
CL_BLOCK 91,380
L1_BATCH 30,420,921
L2_BATCH 5,473
CHECKPOINT 28,005

Copy link
Member

@storopoli storopoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK b2b448d
Thanks!

@storopoli storopoli added this pull request to the merge queue Feb 7, 2025
Merged via the queue into main with commit 044353e Feb 7, 2025
17 of 19 checks passed
@storopoli storopoli deleted the datatool-evm-genesis branch February 7, 2025 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants