Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(btcio): refactor and Clone #659

Merged
merged 2 commits into from
Feb 11, 2025
Merged

feat(btcio): refactor and Clone #659

merged 2 commits into from
Feb 11, 2025

Conversation

storopoli
Copy link
Member

@storopoli storopoli commented Feb 7, 2025

Description

  • Moves submit_package to BroadcasterRpc from ReaderRpc, it is a broadcasting thing anyways.
  • Adds Clone to BitcoinClient so that it can be cloned. This will help out a lot in the strata-bridge's Duty Tracker.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature/Enhancement (non-breaking change which adds functionality or enhances an existing one)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactor
  • New or updated tests
  • Dependency Update

Checklist

  • I have performed a self-review of my code.
  • I have commented my code where necessary.
  • I have updated the documentation if needed.
  • My changes do not introduce new warnings.
  • I have added tests that prove my changes are effective or that my feature works.
  • New and existing tests pass with my changes.

@storopoli storopoli requested a review from a team as a code owner February 7, 2025 21:32
ProofOfKeags
ProofOfKeags previously approved these changes Feb 7, 2025
Copy link

codecov bot commented Feb 7, 2025

Codecov Report

Attention: Patch coverage is 63.15789% with 7 lines in your changes missing coverage. Please review.

Project coverage is 54.73%. Comparing base (004be7c) to head (a8e1c4c).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
crates/btcio/src/test_utils.rs 46.15% 7 Missing ⚠️
@@            Coverage Diff             @@
##             main     #659      +/-   ##
==========================================
+ Coverage   54.68%   54.73%   +0.05%     
==========================================
  Files         317      317              
  Lines       33929    33929              
==========================================
+ Hits        18553    18571      +18     
+ Misses      15376    15358      -18     
Files with missing lines Coverage Δ
crates/btcio/src/rpc/client.rs 85.86% <100.00%> (ø)
crates/btcio/src/test_utils.rs 62.10% <46.15%> (ø)

... and 5 files with indirect coverage changes

Copy link
Contributor

github-actions bot commented Feb 7, 2025

Commit: 972c233

SP1 Performance Test Results

program cycles success
BTC_BLOCKSPACE 30,370,596
EL_BLOCK 97,975
CL_BLOCK 89,783
L1_BATCH 30,419,814
L2_BATCH 3,566
CHECKPOINT 25,699

@storopoli storopoli added this pull request to the merge queue Feb 11, 2025
Merged via the queue into main with commit a11c914 Feb 11, 2025
18 of 19 checks passed
@storopoli storopoli deleted the storopoli/btcio-rpc-fixes branch February 11, 2025 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants