Update GitHub Actions workflows with .nvmrc
#610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All browser tests were successful 
|
colinrotherham
force-pushed
the
configure-node
branch
from
aaff25b
to
ee94844
Compare
Also update CONTRIBUTING.md to match
Allows for `pull_request` status checks, every `push` to main branch, but also enables manual `workflow_dispatch` runs
Also ensures job names match concurrency group names
colinrotherham
force-pushed
the
configure-node
branch
from
ee94844
to
4e9caf8
Compare
colinrotherham
changed the title
.nvmrc
domoscargin
approved these changes
Nov 29, 2023
| ``` | ||
|
|
||
| To install Node (with npm) and Java locally on macOS, we recommend [brew](https://brew.sh) with | ||
| To install Node (with npm) locally on macOS, we recommend [brew](https://brew.sh) with |
There was a problem hiding this comment.
Phew, I saw Java in the first commit and thought I'd have to brush up...
|
|
||
| - name: "Setup Node v${{ steps.nvm.outputs.NVMRC }}" | ||
| uses: actions/setup-node@v2 | ||
| - name: Setup Node.js |
| jobs: | ||
| test-saucelabs: | ||
| integration: |
There was a problem hiding this comment.
Oh, interesting - was this just misnamed as test-saucelabs?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses deprecation warnings in GitHub Actions ahead of package updates
I've included an .nvmrc update
to test things out but this might land in #609 firstcherry picked from c7995df