Refactor Build Workflow for ARM Build Support #1820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dj-maisy
force-pushed
the
dj-maisy/arm-workflow
branch
from
035501c to
6e72b76
Compare
|
I've done a rebase and updated the patch versions in the matrix. |
kentsanggds
reviewed
Sep 9, 2024
dj-maisy
force-pushed
the
dj-maisy/arm-workflow
branch
from
07e36ca to
b089f40
Compare
kentsanggds
reviewed
Sep 17, 2024
kentsanggds
force-pushed
the
dj-maisy/arm-workflow
branch
from
95d628f to
8691d56
Compare
kentsanggds
approved these changes
Sep 24, 2024
Refactor build workflow to suppot ARM builds Update other workflows. Update patch versions used in build matrix. Make multiarch flow the default (for testing) Set the default gitRef input to main.
Make the gitRef input optional, default to branch Fix possible syntax issue in Determine Tags Step Try extra output to cover build arch issue Try using digest to build follow-up base image There is no digest exporter, bad documentation. Correct bad bash script in manifest job. Try fixing the Artifact Pattern Combine Job missing Strategy Config Fix the missing configure_builds job in "needs" Remove debug lines. Add tags for patch IDs
There is a reason we don't set the tags at build. Try to solve the duplicate patch tags.
Add Github Context for debugging
dj-maisy
force-pushed
the
dj-maisy/arm-workflow
branch
from
b031c93 to
c3b7459
Compare
|
Done an interactive rebase and squashed most of the surplus commits. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preface
This took quite a bit of work! And sitting and thinking about "how" to make this somewhat maintainable, understandable and also not too repetitive/redundant. Always happy for suggestions, recommendations, constructive criticisms etc.
What?
This creates a new Workflow file for CKAN/DGU builds to create ARM versions of each of the different images. The new workflow tries to do-away with the current
build-image.shbash script and move a lot of the logic into the Workflow itself. The hope is that this will make the workflow a little easier to debug if anything goes wrong.This PR also creates a new
build-config.yamlfile that contains the various app versions, tags and also the "build types" and which apps each of those build types will actually build, using YAML anchors to try and de-duplicate as much of it as possible. This is a slight deviation from the JSON config file we used for the GOV.UK Ruby Bases, which had a lot less to duplicate. This file is also where we put the runner type configuration.Related