Remove 'previous roles' from person pages

alphagov · Aug 6, 2024 · 23b2634 · 23b2634
1 parent 2385d8b
commit 23b2634
Show file tree

Hide file tree

Showing 71 changed files with 0 additions and 195 deletions.
diff --git a/app/models/person.rb b/app/models/person.rb
@@ -26,24 +26,6 @@ def current_roles_title
     current_roles.map { |role| role["title"] }.to_sentence(locale: content_item.locale)
   end
 
-  def previous_roles_items
-    previous_roles.map do |role|
-      {
-        link: {
-          text: role["title"],
-          path: role["base_path"],
-        },
-        metadata: {
-          appointment_duration: "#{role['start_year']} to #{role['end_year']}",
-        },
-      }
-    end
-  end
-
-  def has_previous_roles?
-    previous_roles.present?
-  end
-
   def image_url
     details.dig("image", "url")
   end
@@ -101,18 +83,6 @@ def previous_role_appointments
     @previous_role_appointments ||= role_appointments(current: false)
   end
 
-  def previous_roles
-    previous_role_appointments
-      .sort_by { |role_appointment| role_appointment["details"]["started_on"] }
-      .reverse
-      .map do |role_appointment|
-        role_appointment["links"]["role"].first.tap do |role|
-          role["start_year"] = Time.zone.parse(role_appointment["details"]["started_on"]).strftime("%Y")
-          role["end_year"] = Time.zone.parse(role_appointment["details"]["ended_on"]).strftime("%Y")
-        end
-      end
-  end
-
   def links
     @content_item.content_item_data["links"]
   end

diff --git a/app/views/people/_contents.html.erb b/app/views/people/_contents.html.erb
@@ -11,11 +11,6 @@
         href: "#current-roles"
       } : nil,
 
-      person.has_previous_roles? ? {
-        text: t("people.previous_roles"),
-        href: "#previous-roles"
-      } : nil,
-
       person.announcements.items.present? ? {
         text: t("shared.schema_name.announcement.other"),
         href: "#announcements"

diff --git a/app/views/people/_previous_roles.html.erb b/app/views/people/_previous_roles.html.erb
diff --git a/app/views/people/show.html.erb b/app/views/people/show.html.erb
@@ -15,7 +15,6 @@
   <div class="govuk-grid-column-two-thirds">
     <%= render partial: "biography", locals: { person: person } %>
     <%= render partial: "current_roles", locals: { person: person } %>
-    <%= render partial: "previous_roles", locals: { person: person } %>
     <%= render partial: "shared/announcements", locals: { announcements: person.announcements, locale: I18n.locale } %>
   </div>
 </div>
diff --git a/config/locales/ar/people.yml b/config/locales/ar/people.yml
@@ -2,6 +2,4 @@
 ar:
   people:
     biography: سيرة ذاتية
-    previous_roles: الأدوار السابقة
-    previous_roles_in_government: الأدوار السابقة بالحكومة
     read_more: المزيد عن هذه الشخصية
diff --git a/config/locales/az/people.yml b/config/locales/az/people.yml
@@ -2,6 +2,4 @@
 az:
   people:
     biography: Bioqrafiya
-    previous_roles: Əvvəlki vəzifələri
-    previous_roles_in_government: Hökumət orqanında əvvəlki vəzifələri
     read_more: Bu şəxs haqqında ətraflı
diff --git a/config/locales/be/people.yml b/config/locales/be/people.yml
@@ -2,6 +2,4 @@
 be:
   people:
     biography: Бiяграфiя
-    previous_roles: Папярэднія пасады
-    previous_roles_in_government: Папярэднія дзяржаўныя пасады
     read_more: Больш аб гэтай персоне
diff --git a/config/locales/bg/people.yml b/config/locales/bg/people.yml
@@ -2,6 +2,4 @@
 bg:
   people:
     biography: Биография
-    previous_roles: Предишни длъжности
-    previous_roles_in_government: Предишни длъжности в правителството
     read_more: Повече за това лице
diff --git a/config/locales/bn/people.yml b/config/locales/bn/people.yml
@@ -2,6 +2,4 @@
 bn:
   people:
     biography: জীবনী
-    previous_roles: পূর্ববর্তী ভূমিকা
-    previous_roles_in_government: সরকারে পূর্ববর্তী ভূমিকা
     read_more: এই ব্যক্তি সম্পর্কে আরও
diff --git a/config/locales/cs/people.yml b/config/locales/cs/people.yml
@@ -2,6 +2,4 @@
 cs:
   people:
     biography: Životopis
-    previous_roles: Předchozí funkce
-    previous_roles_in_government: Předchozí funkce ve státní správě
     read_more: Více o této osobě
diff --git a/config/locales/cy/people.yml b/config/locales/cy/people.yml
@@ -2,6 +2,4 @@
 cy:
   people:
     biography: Bywgraffiad
-    previous_roles: Rolau blaenorol
-    previous_roles_in_government: Rolau blaenorol yn y llywodraeth
     read_more: Mwy am y person hwn
diff --git a/config/locales/da/people.yml b/config/locales/da/people.yml
@@ -2,6 +2,4 @@
 da:
   people:
     biography: Biografi
-    previous_roles: Tidligere roller
-    previous_roles_in_government: Tidligere roller i regeringen
     read_more: Mere om denne person
diff --git a/config/locales/de/people.yml b/config/locales/de/people.yml
@@ -2,6 +2,4 @@
 de:
   people:
     biography: Biografie
-    previous_roles: Frühere Funktionen
-    previous_roles_in_government: Frühere Funktionen in der Regierung
     read_more: Mehr über diese Person
diff --git a/config/locales/dr/people.yml b/config/locales/dr/people.yml
@@ -2,6 +2,4 @@
 dr:
   people:
     biography: بیوگرافی
-    previous_roles: وظیفه هایی قبلی
-    previous_roles_in_government: وظیفه هایی قبلی در دولت
     read_more: اطلاعات بیشتر در بارهء این شخص
diff --git a/config/locales/el/people.yml b/config/locales/el/people.yml
@@ -2,6 +2,4 @@
 el:
   people:
     biography: Βιογραφία
-    previous_roles: Προηγούμενοι ρόλοι
-    previous_roles_in_government: Προηγούμενοι ρόλοι στην κυβέρνηση
     read_more: Περισσότερα για αυτό το άτομο
diff --git a/config/locales/en/people.yml b/config/locales/en/people.yml
@@ -2,6 +2,4 @@
 en:
   people:
     biography: Biography
-    previous_roles: Previous roles
-    previous_roles_in_government: Previous roles in government
     read_more: More about this person
diff --git a/config/locales/es-419/people.yml b/config/locales/es-419/people.yml
@@ -2,6 +2,4 @@
 es-419:
   people:
     biography: Biografía
-    previous_roles: Funciones anteriores
-    previous_roles_in_government: Funciones anteriores en el gobierno
     read_more: Más información sobre esta persona
diff --git a/config/locales/es/people.yml b/config/locales/es/people.yml
@@ -2,6 +2,4 @@
 es:
   people:
     biography: Biografía
-    previous_roles: Funciones anteriores
-    previous_roles_in_government: Funciones anteriores en el gobierno
     read_more: Más sobre esta persona
diff --git a/config/locales/et/people.yml b/config/locales/et/people.yml
@@ -2,6 +2,4 @@
 et:
   people:
     biography: Biograafia
-    previous_roles: Varasemad rollid
-    previous_roles_in_government: Varasemad rollid valitsuses
     read_more: Rohkem selle isiku kohta
diff --git a/config/locales/fa/people.yml b/config/locales/fa/people.yml
@@ -2,6 +2,4 @@
 fa:
   people:
     biography: زندگی‌نامه
-    previous_roles: نقش‌های قبلی
-    previous_roles_in_government: نقش‌های قبلی در دولت
     read_more: اطلاعات بیشتر درباره این فرد
diff --git a/config/locales/fi/people.yml b/config/locales/fi/people.yml
@@ -2,6 +2,4 @@
 fi:
   people:
     biography: Elämäkerta
-    previous_roles: Aiemmat roolit
-    previous_roles_in_government: Aiemmat tehtävät julkishallinnossa
     read_more: Lisää tästä henkilöstä
diff --git a/config/locales/fr/people.yml b/config/locales/fr/people.yml
@@ -2,6 +2,4 @@
 fr:
   people:
     biography: Biographie
-    previous_roles: Rôles précédents
-    previous_roles_in_government: Rôles précédents au gouvernement
     read_more: Plus d'informations sur cette personne
diff --git a/config/locales/gd/people.yml b/config/locales/gd/people.yml
@@ -2,6 +2,4 @@
 gd:
   people:
     biography: Beathaisnéis
-    previous_roles: Feidhmeanna roimhe seo
-    previous_roles_in_government: Róil a bhí ar siúl roimhe seo ag Aireacht an Taobh istigh
     read_more: Níos mó a fhoghlaim faoin duine seo
diff --git a/config/locales/gu/people.yml b/config/locales/gu/people.yml
@@ -2,6 +2,4 @@
 gu:
   people:
     biography: જીવનચરિત્ર
-    previous_roles: અગાઉની ભૂમિકાઓ
-    previous_roles_in_government: સરકારમાં અગાઉની ભૂમિકાઓ
     read_more: આ વ્યક્તિ વિશે વધુ
diff --git a/config/locales/he/people.yml b/config/locales/he/people.yml
@@ -2,6 +2,4 @@
 he:
   people:
     biography: ביוגרפיה
-    previous_roles: תפקידים קודמים
-    previous_roles_in_government: תפקידים קודמים בממשלה
     read_more: עוד על האדם הזה
diff --git a/config/locales/hi/people.yml b/config/locales/hi/people.yml
@@ -2,6 +2,4 @@
 hi:
   people:
     biography: जीवनी
-    previous_roles: पिछली भूमिकाएं
-    previous_roles_in_government: सरकार में पिछली भूमिकाएं
     read_more: इस व्यक्ति के बारे में और बातें
diff --git a/config/locales/hr/people.yml b/config/locales/hr/people.yml
@@ -2,6 +2,4 @@
 hr:
   people:
     biography: Biografija
-    previous_roles: Prethodne uloge
-    previous_roles_in_government: Ranije uloge u vladi
     read_more: Više o ovoj osobi
diff --git a/config/locales/hu/people.yml b/config/locales/hu/people.yml
@@ -2,6 +2,4 @@
 hu:
   people:
     biography: Életrajz
-    previous_roles: Korábbi beosztások
-    previous_roles_in_government: Korábbi állami beosztások
     read_more: Több erről a személyről
diff --git a/config/locales/hy/people.yml b/config/locales/hy/people.yml
@@ -2,6 +2,4 @@
 hy:
   people:
     biography: Կենսագրություն
-    previous_roles: Նախկին պաշտոններ
-    previous_roles_in_government: Նախկին պաշտոններ կառավարությունում
     read_more: Ավելի շատ տեղեկություն այս անձի մասին
diff --git a/config/locales/id/people.yml b/config/locales/id/people.yml
@@ -2,6 +2,4 @@
 id:
   people:
     biography: Biografi
-    previous_roles: Peran sebelumnya
-    previous_roles_in_government: Peran sebelumnya dalam pemerintahan
     read_more: Selengkapnya tentang orang ini
diff --git a/config/locales/is/people.yml b/config/locales/is/people.yml
@@ -2,6 +2,4 @@
 is:
   people:
     biography: Ævisaga
-    previous_roles: Fyrri hlutverki
-    previous_roles_in_government: Fyrri hlutverk hjá ríkinu
     read_more: Meira um þessa manneskju
diff --git a/config/locales/it/people.yml b/config/locales/it/people.yml
@@ -2,6 +2,4 @@
 it:
   people:
     biography: Biografia
-    previous_roles: Ruoli precedenti
-    previous_roles_in_government: Ruoli precedenti nel governo
     read_more: Maggiori informazioni su questa persona
diff --git a/config/locales/ja/people.yml b/config/locales/ja/people.yml
@@ -2,6 +2,4 @@
 ja:
   people:
     biography: 経歴
-    previous_roles: 以前の役割
-    previous_roles_in_government: 政府における以前の役割
     read_more: この人についての詳細
diff --git a/config/locales/ka/people.yml b/config/locales/ka/people.yml
@@ -2,6 +2,4 @@
 ka:
   people:
     biography: ბიოგრაფია
-    previous_roles: წინა როლები
-    previous_roles_in_government: წინა რომელი სახელმწიფოში
     read_more: მეტი ამ ადამიანის შესახებ
diff --git a/config/locales/kk/people.yml b/config/locales/kk/people.yml
@@ -2,6 +2,4 @@
 kk:
   people:
     biography: Биография
-    previous_roles: Алдыңғы рөлдер
-    previous_roles_in_government: Мемлекеттегі алдыңғы рөлдер
     read_more: Осы адам туралы қосымша ақпарат
diff --git a/config/locales/ko/people.yml b/config/locales/ko/people.yml
@@ -2,6 +2,4 @@
 ko:
   people:
     biography: 약력
-    previous_roles: 이전 역할
-    previous_roles_in_government: 정부 내 이전 역할
     read_more: 이 사람에 대해 자세히 살펴보기
diff --git a/config/locales/lt/people.yml b/config/locales/lt/people.yml
@@ -2,6 +2,4 @@
 lt:
   people:
     biography: Biografija
-    previous_roles: Ankstesnė funkcija
-    previous_roles_in_government: Ankstesnė funkcija vyriausybėje
     read_more: Daugiau informacijos apie šį asmenį
diff --git a/config/locales/lv/people.yml b/config/locales/lv/people.yml
@@ -2,6 +2,4 @@
 lv:
   people:
     biography: Biogrāfija
-    previous_roles: Iepriekšējie amati
-    previous_roles_in_government: Iepriekšējie amati valdībā
     read_more: Vairāk par šo personu
diff --git a/config/locales/ms/people.yml b/config/locales/ms/people.yml
@@ -2,6 +2,4 @@
 ms:
   people:
     biography: Biografi
-    previous_roles: Peranan sebelum ini
-    previous_roles_in_government: Peranan sebelum ini dalam kerajaan
     read_more: Lebih lanjut tentang individu ini
diff --git a/config/locales/mt/people.yml b/config/locales/mt/people.yml
@@ -2,6 +2,4 @@
 mt:
   people:
     biography: Bijografija
-    previous_roles: Rwolijiet preċedenti
-    previous_roles_in_government: Rwolijiet preċedenti fil-gvern
     read_more: Iktar dwar din il-persuna
diff --git a/config/locales/ne/people.yml b/config/locales/ne/people.yml
@@ -2,6 +2,4 @@
 ne:
   people:
     biography:
-    previous_roles:
-    previous_roles_in_government:
     read_more:
diff --git a/config/locales/nl/people.yml b/config/locales/nl/people.yml
@@ -2,6 +2,4 @@
 nl:
   people:
     biography: Biografie
-    previous_roles: Vorige functies
-    previous_roles_in_government: Eerdere functies bij de overheid
     read_more: Meer over deze persoon
diff --git a/config/locales/no/people.yml b/config/locales/no/people.yml
@@ -2,6 +2,4 @@
 'no':
   people:
     biography: Biografi
-    previous_roles: Tidligere roller
-    previous_roles_in_government: Tidligere roller i regjeringen
     read_more: Mer om denne personen
diff --git a/config/locales/pa-pk/people.yml b/config/locales/pa-pk/people.yml
@@ -2,6 +2,4 @@
 pa-pk:
   people:
     biography: سوانح حیات
-    previous_roles: پچھلے کردار
-    previous_roles_in_government: حکومت دے وچ پچھلا کردار
     read_more: ایس بندے بارے کُج ہور
diff --git a/config/locales/pa/people.yml b/config/locales/pa/people.yml
@@ -2,6 +2,4 @@
 pa:
   people:
     biography: ਜੀਵਨੀ
-    previous_roles: ਪਿਛਲੀਆਂ ਭੂਮਿਕਾਵਾਂ
-    previous_roles_in_government: ਸਰਕਾਰ ਵਿੱਚ ਪਿਛਲੀਆਂ ਭੂਮਿਕਾਵਾਂ
     read_more: ਇਸ ਵਿਅਕਤੀ ਬਾਰੇ ਹੋਰ
diff --git a/config/locales/pl/people.yml b/config/locales/pl/people.yml
@@ -2,6 +2,4 @@
 pl:
   people:
     biography: Biografia
-    previous_roles: Poprzednie funkcje
-    previous_roles_in_government: Poprzednie funkcje w rządzie
     read_more: Więcej o tej osobie
diff --git a/config/locales/ps/people.yml b/config/locales/ps/people.yml
@@ -2,6 +2,4 @@
 ps:
   people:
     biography: ژوندلیک
-    previous_roles: پخواني رولونه
-    previous_roles_in_government: په حکومت کې پخوانی رول
     read_more: د دې کس په اړه نور
diff --git a/config/locales/pt/people.yml b/config/locales/pt/people.yml
@@ -2,6 +2,4 @@
 pt:
   people:
     biography: Biografia
-    previous_roles: Cargos anteriores
-    previous_roles_in_government: Cargos anteriores no governo
     read_more: Mais sobre esta pessoa
diff --git a/config/locales/ro/people.yml b/config/locales/ro/people.yml
@@ -2,6 +2,4 @@
 ro:
   people:
     biography: Biografie
-    previous_roles: Roluri anterioare
-    previous_roles_in_government: Roluri anterioare în guvern
     read_more: Mai multe despre această persoană