Skip to content

Commit

Permalink
Merge pull request #3697 from alphagov/roles-page
Browse files Browse the repository at this point in the history
Improve headings on Roles pages
  • Loading branch information
andysellick authored Jul 12, 2024
2 parents bc52df6 + 77f7ccb commit 26b5fe3
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 0 deletions.
3 changes: 3 additions & 0 deletions app/views/roles/_current_role_holder_with_biography.html.erb
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,13 @@
<%= render "govuk_publishing_components/components/heading", {
text: t("roles.headings.current_holder"),
lang: t_fallback("roles.headings.current_holder"),
margin_bottom: 2,
} %>
<%= render "govuk_publishing_components/components/heading", {
text: role.current_holder["title"],
heading_level: 3,
font_size: "m",
margin_bottom: 2,
} %>
Expand Down
2 changes: 2 additions & 0 deletions app/views/roles/_past_role_holders.html.erb
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
<section id="past-role-holders" class="govuk-!-padding-bottom-9">
<%= render "govuk_publishing_components/components/heading", {
text: t("roles.previous_holders"),
margin_bottom: 2,
} %>
<p class="govuk-body" lang="en">
<%= t("roles.find_out_more_html", link: link_to(t("roles.past") + " #{role.title.pluralize}", role.past_holders_url, class: "govuk-link")) %>
Expand All @@ -11,6 +12,7 @@
<section id="past-role-holders" class="govuk-!-padding-bottom-9">
<%= render "govuk_publishing_components/components/heading", {
text: t("roles.previous_holders"),
margin_bottom: 2,
} %>
<%= render "components/taxon_list", {
heading_level: 3,
Expand Down

0 comments on commit 26b5fe3

Please sign in to comment.