Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use heading component on browse pages #3724

Merged
merged 1 commit into from
Aug 5, 2024
Merged

Conversation

andysellick
Copy link
Contributor

@andysellick andysellick commented Aug 5, 2024

⚠️ This repo is Continuously Deployed: make sure you follow the guidance ⚠️

What

Replace hard coded headings in the browse pages with our heading component. Specifically on:

e.g.

Screenshot 2024-08-05 at 11 05 37

Why

There's no obvious reason why this shouldn't be a component - and using the component allows us to remove a few lines of CSS.

Visual changes

None.

- replace hard coded headings with our heading component
@govuk-ci govuk-ci temporarily deployed to collections-pr-3724 August 5, 2024 10:04 Inactive
@andysellick andysellick marked this pull request as ready for review August 5, 2024 10:06
Copy link
Contributor

@matthillco matthillco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@andysellick andysellick merged commit 3847364 into main Aug 5, 2024
15 checks passed
@andysellick andysellick deleted the use-heading-component branch August 5, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants