Do not force analytics labels for popular links to be in English and refactor browse helper #3726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unoduetre
force-pushed
the
2761-refactor-browsehelper-in-preparation-for-ab-test-m
branch
from
3dff161
to
d13158b
Compare
unoduetre
force-pushed
the
2761-refactor-browsehelper-in-preparation-for-ab-test-m
branch
2 times, most recently
from
ea77c61
to
c8f82e0
Compare
hannako
reviewed
Aug 12, 2024
unoduetre
changed the title
unoduetre
changed the title
unoduetre
force-pushed
the
2761-refactor-browsehelper-in-preparation-for-ab-test-m
branch
6 times, most recently
from
ddc8c7b
to
57374d6
Compare
hannako
reviewed
Aug 15, 2024
|
@andysellick We're doing a bit of a refactor before we add some AB test logic. I've checked the tracking isn't impacted by comparing the review app with live, but would you mind giving it a quick once over as well just from the tracking POV to make sure we've not broken anything? Browse business Browse benefits |
In preparation for popular links AB test
unoduetre
force-pushed
the
2761-refactor-browsehelper-in-preparation-for-ab-test-m
branch
from
57374d6
to
b40ea66
Compare
unoduetre
deleted the
2761-refactor-browsehelper-in-preparation-for-ab-test-m
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow these steps if you are doing a Rails upgrade.
What
In preparation for adding the AB test configuration to collections, we can refactor the way the code is currently organised.
In addition to that, do not force the analytics labels of popular links to always be in English.
Why
Trello card