Add variant A and B links for PopularTasks AB test #3744
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Popular tasks are currently present on business and benefits pages only. As part of our AB test, we will be adding 3 popular tasks to all level 2 browse pages. This commit preps the file for the incoming data. govuk-docker-run rake translation:add_missing has not been run - so the keys are missing from other locale files. This is intentional. Browse pages are not currently translated, and there is no intention of implementing translations. This AB test code is temporary and will be removed in a few weeks. Adding empty keys will just make the diff harder to review and reverting the code more time consuming.
hannako
force-pushed
the
add_popular_browse_ab_test_links
branch
from
d97f9e0
to
f2ab81a
Compare
unoduetre
approved these changes
Aug 22, 2024
unoduetre
requested changes
Aug 22, 2024
For variants A and B, all browse pages will contain popular links. For variants C and Z ie the control state, only business and benefits will contain popular links. The other 14 will default to hiding popular tasks entirely - as this is the default behaviour currently live on GOV.UK This commit adds specs to highlight this, and simplifies the existing code. There is no behavioural change.
hannako
force-pushed
the
add_popular_browse_ab_test_links
branch
from
f2ab81a
to
452215a
Compare
unoduetre
approved these changes
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Add URL's and titles for variants A and B for the upcoming PopularTasks AB test
This PR will be easier to review commit by commit
Variant A is most searched for destination pages from the browse page. The data has come from this sheet
Variant B is most viewed content tagged to any browse subtopic. The data has come from this sheet
How to test
Install Modheader or similar tool
Set the following request header, and toggle variants A, B, C or Z
Review apps
Screenshot example (for browse benefits)
Related work:
Trello card: https://trello.com/c/cy7wYrdz/2803-add-variant-a-and-variant-b-links-to-collections