Reintroduce hash sorting for expanded content-item and links #1100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aldavidson
force-pushed
the
re-add-hash-sort-correctly
branch
from
67a000b
to
7a5fea2
Compare
…rectly this time enforce internal consistency of sym/string keys for ExpandedLinksPresenter and ContentItemPresenter
aldavidson
force-pushed
the
re-add-hash-sort-correctly
branch
from
7a5fea2
to
cc390d0
Compare
brucebolt
approved these changes
Jun 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an updated version of PR #1096, having isolated the cause of the problem described in #1097 (
.deep_symbolize_keyscalled at the wrong level) and added a test case to catch the issue in #1099, plus explicit tests that the sorting behaviour is correct.Trello cards 1 and 2
Manual Testing
I've deployed this to integration and tested that :
a) this does not drop the
role_appointments[*] -> links(as was found in #1096) :Before on the left, after on the right. Also note the hashes on the right are sorted at all levels
b) the page renders correctly in the
collectionsfront end:This application is owned by the publishing platform team. Please let us know in #govuk-publishing-platform when you raise any PRs.
Follow these steps if you are doing a Rails upgrade.