Skip to content

Commit

Permalink
Merge pull request #421 from alphagov/autocomplete-scroll-fix
Browse files Browse the repository at this point in the history
Remove all tabindexes
  • Loading branch information
maxf authored Feb 21, 2018
2 parents 1506366 + 74399cb commit fff128e
Show file tree
Hide file tree
Showing 11 changed files with 12 additions and 12 deletions.
2 changes: 1 addition & 1 deletion app/views/consents/new.html.erb
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<main role="main" tabindex="-1" id="content">
<main role="main" id="content">
<div class="grid-row inner">
<%= render partial: 'layouts/feedback_survey_banner' if flash[:beta_message] == 'hide'%>

Expand Down
2 changes: 1 addition & 1 deletion app/views/datasets/show.html.erb
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<%= @dataset.title %> -
<% end %>

<main role="main" tabindex="-1" id="content">
<main role="main" id="content">
<%= render partial: 'layouts/feedback_survey_banner' if flash[:beta_message] == 'hide'%>
<%= render "breadcrumb" %>
<div itemscope itemtype="http://schema.org/Dataset">
Expand Down
2 changes: 1 addition & 1 deletion app/views/home/index.html.erb
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<div class="dgu-split-background">
<main role="main" tabindex="-1" id="content">
<main role="main" id="content">
<%= render 'search' %>
<%= render 'topics' %>
</main>
Expand Down
2 changes: 1 addition & 1 deletion app/views/layouts/search.html.erb
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
<%= render 'layouts/staging_ribbon' if Rails.env.staging? %>
<%= render 'layouts/beta_message' if flash[:beta_message] == 'show' %>
<div class="dgu-beta__message--<%=flash[:beta_message] %>">
<main role="main" tabindex="-1" id="content">
<main role="main" id="content">
<%= yield %>
</main>
</div>
Expand Down
2 changes: 1 addition & 1 deletion app/views/pages/about.html.erb
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
About data.gov.uk -
<% end %>

<main role="main" tabindex="-1" id="content">
<main role="main" id="content">
<%= render partial: 'layouts/feedback_survey_banner' if flash[:beta_message] == 'hide'%>

<h1 class="heading-large">
Expand Down
2 changes: 1 addition & 1 deletion app/views/pages/accessibility.html.erb
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
Accessibility -
<% end %>

<main role="main" tabindex="-1" id="content">
<main role="main" id="content">
<%= render partial: 'layouts/feedback_survey_banner' if flash[:beta_message] == 'hide'%>

<h1 class="heading-large">
Expand Down
2 changes: 1 addition & 1 deletion app/views/pages/cookies.html.erb
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
Cookies -
<% end %>

<main role="main" tabindex="-1" id="content">
<main role="main" id="content">
<%= render partial: 'layouts/feedback_survey_banner' if flash[:beta_message] == 'hide'%>

<h1 class="heading-xlarge">
Expand Down
2 changes: 1 addition & 1 deletion app/views/pages/privacy.html.erb
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
Privacy -
<% end %>

<main role="main" tabindex="-1" id="content">
<main role="main" id="content">
<%= render partial: 'layouts/feedback_survey_banner' if flash[:beta_message] == 'hide'%>

<h1 class="heading-large">
Expand Down
2 changes: 1 addition & 1 deletion app/views/pages/support.html.erb
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
Support -
<% end %>

<main role="main" tabindex="-1" id="content">
<main role="main" id="content">
<%= render partial: 'layouts/feedback_survey_banner' if flash[:beta_message] == 'hide'%>

<div class="grid-row inner">
Expand Down
2 changes: 1 addition & 1 deletion app/views/pages/terms.html.erb
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
Terms and conditions -
<% end %>

<main role="main" tabindex="-1" id="content">
<main role="main" id="content">
<%= render partial: 'layouts/feedback_survey_banner' if flash[:beta_message] == 'hide'%>

<h1 class="heading-large">
Expand Down
4 changes: 2 additions & 2 deletions app/views/tickets/new.html.erb
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
Send a data request -
<% end %>

<main role="main" tabindex="-1" id="content">
<main role="main" id="content">
<div class="grid-row inner">
<div class="column-full">

Expand All @@ -14,7 +14,7 @@
</ol>
</div>
<% if @ticket.errors.any? %>
<div class="error-summary" role="alert" aria-labelledby="error-summary-heading" tabindex="-1">
<div class="error-summary" role="alert" aria-labelledby="error-summary-heading">
<h2 class="heading-medium error-summary-heading" id="error-summary-heading">
There was a problem
</h2>
Expand Down

0 comments on commit fff128e

Please sign in to comment.