-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add basic dataset page #1315
Open
deborahchua
wants to merge
8
commits into
main-solr
Choose a base branch
from
add-basic-dataset-page
base: main-solr
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add basic dataset page #1315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To display information for an individual dataset we need to be able to query by searching for the UUID in the `ID` field available in Solr. This is passed into the Solr query as the `fq` (filter queries) parameter.
We can also use Active Model to process the Solr data and present information in the view.
deborahchua
force-pushed
the
add-basic-dataset-page
branch
from
October 8, 2024 10:09
d42fce8
to
cc6e5d8
Compare
This commit shows the publisher, last updated and summary in the metadata box. If the topic and licence information is available they will also be included.
- Fix failing tests (commented out for now)
deborahchua
force-pushed
the
add-basic-dataset-page
branch
from
October 8, 2024 10:22
cc6e5d8
to
078e02a
Compare
This was referenced Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the basic dataset page and includes:
The dataset pages are also linked to from the search results page.
This has been tested on Integration.
See individual commits for more detail.