use dynamic value for the filter sections count

alphagov · Oct 4, 2024 · 3fe3971 · 3fe3971
1 parent 030e35e
commit 3fe3971
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 5 deletions.
diff --git a/app/views/components/_filter_panel.html.erb b/app/views/components/_filter_panel.html.erb
@@ -7,6 +7,7 @@
   panel_content_id = "filter-panel-#{id_suffix}"
   button_id = "filter-button-#{id_suffix}"
   result_text ||= ""
+  section_count ||= ""
 
   show_reset_link ||= false
   raise ArgumentError, "reset_link_href is required" if show_reset_link && !local_assigns[:reset_link_href]
@@ -31,7 +32,7 @@
         section: button_text,
         text: button_text,
         index_section: 0,
-        index_section_count: 4
+        index_section_count: section_count
       }.to_json
     ) { button_text } %>
 
@@ -61,7 +62,7 @@
           section: button_text,
           action: "search",
           index_section: 0,
-          index_section_count: 4,
+          index_section_count: section_count,
         }.to_json %>
 
       <% if show_reset_link %>

diff --git a/app/views/finders/show_all_content_finder.html.erb b/app/views/finders/show_all_content_finder.html.erb
@@ -52,6 +52,7 @@
           open: @search_query.invalid?,
           show_reset_link: filters_presenter.any_filters?,
           reset_link_href: filters_presenter.reset_url,
+          section_count: facets.user_visible_count,
         } do %>
           <% facets.each_with_visible_index_and_count do |facet, index, count| %>
             <%=

diff --git a/spec/components/filter_panel_spec.rb b/spec/components/filter_panel_spec.rb
@@ -79,24 +79,26 @@ def render_component(locals, &block)
 
   it "renders ga4 tracking attributes to open/close button element" do
     button_text = "Filter"
+    section_count = 4
 
     button_event_attributes = {
       event_name: "select_content",
       type: "finder",
       section: button_text,
       text: button_text,
       index_section: 0,
-      index_section_count: 4,
+      index_section_count: section_count,
     }
 
-    render_component(button_text:)
+    render_component(button_text:, section_count:)
 
     assert_select ".app-c-filter-panel button[data-ga4-expandable]", true
     assert_select ".app-c-filter-panel button[data-ga4-event='#{button_event_attributes.to_json}']", true
   end
 
   it "renders ga4 tracking attributes to submit button element" do
     button_text = "Apply filters"
+    section_count = 4
 
     button_event_attributes = {
       event_name: "select_content",
@@ -108,7 +110,7 @@ def render_component(locals, &block)
       index_section_count: 4,
     }
 
-    render_component(button_text:)
+    render_component(button_text:, section_count:)
 
     assert_select ".app-c-filter-panel__action--submit[data-ga4-event='#{button_event_attributes.to_json}']", true
   end