Skip to content

Commit

Permalink
Merge pull request #3469 from alphagov/ga4-date-tracking
Browse files Browse the repository at this point in the history
Update `govuk_publishing_components` to 43.4.1; fix GA4 spec
  • Loading branch information
csutter authored Sep 23, 2024
2 parents 0114d15 + 3b8b1d9 commit 4d005fd
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions Gemfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -187,7 +187,7 @@ GEM
govuk_personalisation (1.0.0)
plek (>= 1.9.0)
rails (>= 6, < 8)
govuk_publishing_components (43.1.1)
govuk_publishing_components (43.4.1)
govuk_app_config
govuk_personalisation (>= 0.7.0)
kramdown
Expand Down Expand Up @@ -545,7 +545,7 @@ GEM
mime-types (>= 1.16, < 4.0)
netrc (~> 0.8)
rexml (3.3.7)
rouge (4.3.0)
rouge (4.4.0)
rspec-core (3.13.1)
rspec-support (~> 3.13.0)
rspec-expectations (3.13.2)
Expand Down
4 changes: 2 additions & 2 deletions spec/javascripts/analytics-ga4/ga4-finder-tracker.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ describe('GA4 finder change tracker', function () {

input = document.createElement('input')
input.setAttribute('type', 'search')
input.value = 'Hello world my postcode is SW1A 0AA. My birthday is 1970-01-01. My email is [email protected]'
input.value = 'Hello world my postcode is SW1A 0AA. My email is [email protected]'

inputParent.appendChild(input)
form.appendChild(inputParent)
Expand All @@ -67,7 +67,7 @@ describe('GA4 finder change tracker', function () {

expected.event_data.event_name = 'search'
expected.event_data.url = window.location.pathname
expected.event_data.text = 'hello world my postcode is [postcode]. my birthday is [date]. my email is [email]'
expected.event_data.text = 'hello world my postcode is [postcode]. my email is [email]'
expected.event_data.section = 'Search'
expected.event_data.action = 'search'

Expand Down

0 comments on commit 4d005fd

Please sign in to comment.