Merge pull request #3452 from alphagov/handle-unfiltered-parameters

updated code to handle unfiltered parameters
alphagov · Sep 24, 2024 · 905720d · 905720d
2 parents a7fa98a + 9e913bd
commit 905720d
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/app/controllers/finders_controller.rb b/app/controllers/finders_controller.rb
@@ -45,7 +45,7 @@ def show
         end
       end
     end
-  rescue ActionController::UnknownFormat
+  rescue ActionController::UnknownFormat, ActionController::UnfilteredParameters
     render plain: "Not acceptable", status: :not_acceptable
   rescue UnsupportedContentItem
     render plain: "Not found", status: :not_found

diff --git a/spec/controllers/finders_controller_spec.rb b/spec/controllers/finders_controller_spec.rb
@@ -484,6 +484,11 @@
       it "redirects to research-and-statistics finder for statistics" do
         expect(get(:show, params: @default_params.merge(publication_type: "statistics"))).to redirect_to("/search/research-and-statistics")
       end
+
+      it "returns a 406 if there are unfiltered parameters" do
+        get(:show, params: @default_params.merge(publication_type: "foi-releases", organisations: { foo: "bar" }))
+        expect(response.status).to eq(406)
+      end
     end
 
     describe "when there are legacy parameters present" do